Re: [Qemu-devel] [PATCH v2 4/5] test: Postcopy

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Marcel Apfelbaum (marcel@redhat.com) wrote:

> > > > > > +int main(int argc, char **argv)
> > > > > > +{
> > > > > > +    char template[] = "/tmp/postcopy-test-XXXXXX";
> > > > > 
> > > > > I would not explicitly use /tmp/
> > > > 
> > > > The ivshmem-test, vhost-user-test and test-qga seem to do it this way;
> > > > what's your preferred fix?
> > > 
> > > You could use the P_tmpdir macro instead of '/tmp', but again,
> > > if all the tests assume /tmp existence maybe is not an issue.
> > 
> > I don't see any use of P_tmpdir in qemu at all; we do have one use of
> > g_get_tmp_dir (in util/memfd.c).
> 
> Even better! I like the way it look for it:
>     On UNIX, this is taken from the TMPDIR environment variable.
>     If the variable is not set, P_tmpdir is used, as defined by the system C library.
>     Failing that, a hard-coded default of "/tmp" is returned.

Lets go through and do the /tmp changes another time but to all of
the tests; lets keep them consistent for now.
I've just posted a version with the assert changes you suggested in.

Dave

> 
> > 
> > > > > > +    int ret;
> > > > > > +
> > > > > > +    g_test_init(&argc, &argv, NULL);
> > > > > > +
> > > > > > +    if (!ufd_version_check()) {
> > > > > > +        return 0;
> > > > > > +    }
> > > > > > +
> > > > > > +    tmpfs = mkdtemp(template);
> > > > > > +    if (!tmpfs) {
> > > > > > +        g_test_message("mkdtemp on path (%s): %s\n", template, strerror(errno));
> > > > > > +    }
> > > > > > +    g_assert(tmpfs);
> > > > > > +
> > > > > > +    module_call_init(MODULE_INIT_QOM);
> > > > > > +
> > > > > > +    qtest_add_func("/postcopy", test_migrate);
> > > > > > +
> > > > > 
> > > > > How much time does this test takes? If is too long, maybe we should not run it
> > > > > automatically as part of make check, but using an environment variable.
> > > > 
> > > > 4 seconds on my laptop; it seems reasonable.
> > > > 
> > > 
> > > make-check takes about 1 and a half minute for x86_64 configuration, 4 seconds
> > > more seems reasonable indeed.
> > 
> > Dave
> > 
> > > Thanks,
> > > Marcel
> > > 
> > > 
> > > > Dave
> > > > --
> > > > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> > > > 
> > > 
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> > 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK