All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	maxime.coquelin@st.com, ohad@wizery.com,
	linux-remoteproc@vger.kernel.org,
	Ludovic Barre <ludovic.barre@st.com>
Subject: Re: [PATCH 2/5] remoteproc: core: Add rproc OF look-up functions
Date: Fri, 6 May 2016 11:48:42 -0700	[thread overview]
Message-ID: <20160506184842.GE1256@tuxbot> (raw)
In-Reply-To: <1462454983-13168-3-git-send-email-lee.jones@linaro.org>

On Thu 05 May 06:29 PDT 2016, Lee Jones wrote:

> - of_rproc_byindex(): look-up and obtain a reference to a rproc
>   		      using the DT phandle "rprocs" and a index.
> 
> - of_rproc_byname():  lookup and obtain a reference to a rproc
>   		      using the DT phandle "rprocs" and "rproc-names".
> 
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---

I like the idea of having these helpers, but we already have
rproc_get_by_phandle() so these helpers should be built upon that rather
than adding the additional list.

Regards,
Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] remoteproc: core: Add rproc OF look-up functions
Date: Fri, 6 May 2016 11:48:42 -0700	[thread overview]
Message-ID: <20160506184842.GE1256@tuxbot> (raw)
In-Reply-To: <1462454983-13168-3-git-send-email-lee.jones@linaro.org>

On Thu 05 May 06:29 PDT 2016, Lee Jones wrote:

> - of_rproc_byindex(): look-up and obtain a reference to a rproc
>   		      using the DT phandle "rprocs" and a index.
> 
> - of_rproc_byname():  lookup and obtain a reference to a rproc
>   		      using the DT phandle "rprocs" and "rproc-names".
> 
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---

I like the idea of having these helpers, but we already have
rproc_get_by_phandle() so these helpers should be built upon that rather
than adding the additional list.

Regards,
Bjorn

  reply	other threads:[~2016-05-06 18:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05 13:29 [PATCH 0/5] remoteproc: A few important improvements Lee Jones
2016-05-05 13:29 ` Lee Jones
2016-05-05 13:29 ` [PATCH 1/5] remoteproc: core: Task sync during rproc_fw_boot() Lee Jones
2016-05-05 13:29   ` Lee Jones
2016-05-06 18:44   ` Bjorn Andersson
2016-05-06 18:44     ` Bjorn Andersson
2016-05-05 13:29 ` [PATCH 2/5] remoteproc: core: Add rproc OF look-up functions Lee Jones
2016-05-05 13:29   ` Lee Jones
2016-05-06 18:48   ` Bjorn Andersson [this message]
2016-05-06 18:48     ` Bjorn Andersson
2016-05-10 14:16     ` Lee Jones
2016-05-10 14:16       ` Lee Jones
2016-05-10 18:48       ` Bjorn Andersson
2016-05-10 18:48         ` Bjorn Andersson
2016-07-13 19:11   ` Bjorn Andersson
2016-07-13 19:11     ` Bjorn Andersson
2016-07-14  6:53     ` Lee Jones
2016-07-14  6:53       ` Lee Jones
2016-05-05 13:29 ` [PATCH 3/5] remoteproc: core: Add ability to select a firmware from the client Lee Jones
2016-05-05 13:29   ` Lee Jones
2016-05-06 18:59   ` Bjorn Andersson
2016-05-06 18:59     ` Bjorn Andersson
2016-05-10 13:02     ` Lee Jones
2016-05-10 13:02       ` Lee Jones
2016-05-05 13:29 ` [PATCH 4/5] remoteproc: core: Supply framework to request, declare and fetch shared memory Lee Jones
2016-05-05 13:29   ` Lee Jones
2016-05-11 22:30   ` Bjorn Andersson
2016-05-11 22:30     ` Bjorn Andersson
2016-06-15 22:06   ` Bjorn Andersson
2016-06-15 22:06     ` Bjorn Andersson
2016-06-21  7:33     ` [STLinux Kernel] " loic pallardy
2016-06-21  7:33       ` loic pallardy
2016-06-21  7:33       ` loic pallardy
2016-06-22 16:21       ` Bjorn Andersson
2016-06-22 16:21         ` Bjorn Andersson
2016-05-05 13:29 ` [PATCH 5/5] remoteproc: core: Clip carveout if it's too big Lee Jones
2016-05-05 13:29   ` Lee Jones
2016-05-10 19:21   ` Bjorn Andersson
2016-05-10 19:21     ` Bjorn Andersson
2016-06-17 19:53     ` [STLinux Kernel] " loic pallardy
2016-06-17 19:53       ` loic pallardy
2016-06-17 19:53       ` loic pallardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160506184842.GE1256@tuxbot \
    --to=bjorn.andersson@linaro.org \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ludovic.barre@st.com \
    --cc=maxime.coquelin@st.com \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.