Re: [PATCH v2] clk: tegra: Initialize UTMIPLL when enabling PLLU

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

On Fri, May 06, 2016 at 04:20:15PM -0400, Rhyland Klein wrote:
> From: Andrew Bresticker <abrestic@chromium.org>
> 
> Move the UTMIPLL initialization code from the clk-tegra<chip>.c
> files into clk-pll.c and perform the initialization sequence when
> PLLU is enabled.
> 
> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> 
> [rklein: Merged in some later fixes for potential deadlocks]
> 
> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
> ---
> v2:
>  - Swapped out __clk_lookup for 2 calls to clk_hw_get_parent
> 
>  drivers/clk/tegra/clk-pll.c      | 484 +++++++++++++++++++++++++++++++++++++++
>  drivers/clk/tegra/clk-tegra114.c | 155 +------------
>  drivers/clk/tegra/clk-tegra124.c | 156 +------------
>  drivers/clk/tegra/clk-tegra210.c | 182 +--------------
>  drivers/clk/tegra/clk-tegra30.c  | 113 +--------
>  drivers/clk/tegra/clk.h          |  17 ++
>  6 files changed, 510 insertions(+), 597 deletions(-)

The commit message should mention *why* this change is necessary. It's
fairly obvious what you're doing by looking at the code, but the commit
message is an opportunity to let others know why this is necessary or
worthwhile. Does it fix a bug? Is this clean up? It seems important to
me when you say "perform the initialization sequence when PLLU is
enabled", but as it is I don't understand why.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]