From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] doc/devicetree: Add Aspeed VIC bindings
Date: Mon, 9 May 2016 16:20:04 +0100 [thread overview]
Message-ID: <20160509152003.GA13842@leverpostej> (raw)
In-Reply-To: <1462797239-14765-2-git-send-email-joel@jms.id.au>
On Mon, May 09, 2016 at 10:03:58PM +0930, Joel Stanley wrote:
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> .../interrupt-controller/aspeed,ast2400-vic.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
> new file mode 100644
> index 000000000000..10ed0c20ee6f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
> @@ -0,0 +1,24 @@
> +Aspeed Vectored Interrupt Controller
> +
> +These bindings are for the Aspeed AST2400 interrupt controller register layout.
> +The SoC has an legacy register layout, but this driver does not support that
> +mode of operation.
> +
> +Required properties:
> +
> +- compatible : should be "aspeed,ast2400-vic".
> +
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> + interrupt source. The value shall be 1.
> +- valid-sources : bitmask of valid irq sources
Generally we steer clear of this kind of bitmap encoding in DT.
Is this actually necessary? What does htis gain us?
Why can we not just register with the full set of possible interrupts?
Thanks,
Mark.
> +
> +Example:
> +
> + vic: interrupt-controller {
> + compatible = "aspeed,ast2400-new-vic";
> + interrupt-controller;
> + #interrupt-cells = <1>;
> + valid-sources = < 0xffffffff 0x0007ffff>;
> + reg = <0x1e6c0080 0x80>;
> + };
> --
> 2.8.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net, arnd@arndb.de,
marc.zyngier@arm.com, benh@kernel.crashing.org, jk@ozlabs.org,
tglx@linutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] doc/devicetree: Add Aspeed VIC bindings
Date: Mon, 9 May 2016 16:20:04 +0100 [thread overview]
Message-ID: <20160509152003.GA13842@leverpostej> (raw)
In-Reply-To: <1462797239-14765-2-git-send-email-joel@jms.id.au>
On Mon, May 09, 2016 at 10:03:58PM +0930, Joel Stanley wrote:
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> .../interrupt-controller/aspeed,ast2400-vic.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
> new file mode 100644
> index 000000000000..10ed0c20ee6f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-vic.txt
> @@ -0,0 +1,24 @@
> +Aspeed Vectored Interrupt Controller
> +
> +These bindings are for the Aspeed AST2400 interrupt controller register layout.
> +The SoC has an legacy register layout, but this driver does not support that
> +mode of operation.
> +
> +Required properties:
> +
> +- compatible : should be "aspeed,ast2400-vic".
> +
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> + interrupt source. The value shall be 1.
> +- valid-sources : bitmask of valid irq sources
Generally we steer clear of this kind of bitmap encoding in DT.
Is this actually necessary? What does htis gain us?
Why can we not just register with the full set of possible interrupts?
Thanks,
Mark.
> +
> +Example:
> +
> + vic: interrupt-controller {
> + compatible = "aspeed,ast2400-new-vic";
> + interrupt-controller;
> + #interrupt-cells = <1>;
> + valid-sources = < 0xffffffff 0x0007ffff>;
> + reg = <0x1e6c0080 0x80>;
> + };
> --
> 2.8.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-05-09 15:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 12:33 [PATCH 0/2] irqchip: Support Aspeed IRQ controller Joel Stanley
2016-05-09 12:33 ` Joel Stanley
2016-05-09 12:33 ` [PATCH 1/2] doc/devicetree: Add Aspeed VIC bindings Joel Stanley
2016-05-09 12:33 ` Joel Stanley
2016-05-09 12:50 ` Baruch Siach
2016-05-09 12:50 ` Baruch Siach
2016-05-09 12:55 ` Arnd Bergmann
2016-05-09 12:55 ` Arnd Bergmann
2016-05-09 15:20 ` Mark Rutland [this message]
2016-05-09 15:20 ` Mark Rutland
2016-05-09 22:04 ` Benjamin Herrenschmidt
2016-05-09 22:04 ` Benjamin Herrenschmidt
2016-05-09 12:33 ` [PATCH 2/2] irqchip: Add irq controller for Aspeed Joel Stanley
2016-05-09 12:33 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509152003.GA13842@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.