All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 3/3] block: enable testing of LUKS driver with block I/O tests
Date: Mon, 9 May 2016 17:45:26 +0100	[thread overview]
Message-ID: <20160509164526.GH14467@redhat.com> (raw)
In-Reply-To: <c9780d9a-018f-6728-48b4-2f96f2f1c20a@redhat.com>

On Fri, May 06, 2016 at 03:32:15PM +0200, Max Reitz wrote:
> On 18.04.2016 14:21, Daniel P. Berrange wrote:
> > This adds support for testing the LUKS driver with the block
> > I/O test framework.
> > 
> >    cd tests/qemu-io-tests
> >    ./check -luks
> > 
> > A handful of test cases are modified to work with luks
> > 
> >  - 004 - whitelist luks format
> >  - 012 - use TEST_IMG_FILE instead of TEST_IMG for file ops
> >  - 048 - use TEST_IMG_FILE instead of TEST_IMG for file ops.
> >          don't assume extended image contents is all zeros,
> >          explicitly initialize with zeros
> >          Make file size smaller to avoid having to decrypt
> >          1 GB of data.
> >  - 052 - don't assume initial image contents is all zeros,
> >          explicitly initialize with zeros
> >  - 100 - don't assume initial image contents is all zeros,
> >          explicitly initialize with zeros
> 
> You're doing that with "write -P 0" in this patch. Would it be possible
> to use "write -z" instead?

Sure, I can switch that.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

      reply	other threads:[~2016-05-09 16:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 12:21 [Qemu-devel] [PATCH v8 0/3] Tests for LUKS driver Daniel P. Berrange
2016-04-18 12:21 ` [Qemu-devel] [PATCH v8 1/3] block: add support for --image-opts in block I/O tests Daniel P. Berrange
2016-05-06 13:20   ` Max Reitz
2016-04-18 12:21 ` [Qemu-devel] [PATCH v8 2/3] block: add support for encryption secrets " Daniel P. Berrange
2016-05-06 13:26   ` Max Reitz
2016-04-18 12:21 ` [Qemu-devel] [PATCH v8 3/3] block: enable testing of LUKS driver with " Daniel P. Berrange
2016-05-06 13:32   ` Max Reitz
2016-05-09 16:45     ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160509164526.GH14467@redhat.com \
    --to=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.