From: Lee Jones <lee.jones@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Guenter Roeck <linux@roeck-us.net>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jiri Slaby <jslaby@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-clk@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [RFC PATCH 01/21] mfd: uniphier: add UniPhier MFD driver
Date: Wed, 11 May 2016 08:38:55 +0100 [thread overview]
Message-ID: <20160511073855.GQ19473@dell> (raw)
In-Reply-To: <CAK7LNATmuN647=avdqAMahLU+9Bq4m4TkXe5f7q=pi8m=UrXBg@mail.gmail.com>
On Wed, 11 May 2016, Masahiro Yamada wrote:
> Hi Lee,
>
> 2016-05-10 20:26 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> >> +};
> >> +MODULE_DEVICE_TABLE(of, uniphier_mfd_match);
> >
> > NACK. Please do not mix MFD and DT registration.
>
> OK, thanks for review.
>
>
> My basic thought was:
>
> - Add an MFD node to my DTS only once.
> If I need to expand it in the future, I will just
> need to modify drivers/mtd/uniphier-mfd.c.
> It is just kernel-internal modification, so it does not
> bother DT binding at all.
>
> - Simplify the node topology of DTS.
Just describe the hardware in DT. If you do so accurately, there
should be no requirement to change it (in theory).
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 01/21] mfd: uniphier: add UniPhier MFD driver
Date: Wed, 11 May 2016 08:38:55 +0100 [thread overview]
Message-ID: <20160511073855.GQ19473@dell> (raw)
In-Reply-To: <CAK7LNATmuN647=avdqAMahLU+9Bq4m4TkXe5f7q=pi8m=UrXBg@mail.gmail.com>
On Wed, 11 May 2016, Masahiro Yamada wrote:
> Hi Lee,
>
> 2016-05-10 20:26 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> >> +};
> >> +MODULE_DEVICE_TABLE(of, uniphier_mfd_match);
> >
> > NACK. Please do not mix MFD and DT registration.
>
> OK, thanks for review.
>
>
> My basic thought was:
>
> - Add an MFD node to my DTS only once.
> If I need to expand it in the future, I will just
> need to modify drivers/mtd/uniphier-mfd.c.
> It is just kernel-internal modification, so it does not
> bother DT binding at all.
>
> - Simplify the node topology of DTS.
Just describe the hardware in DT. If you do so accurately, there
should be no requirement to change it (in theory).
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-05-11 7:38 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 9:50 [RFC PATCH 00/21] mfd, clock, reset: add UniPhier clock/reset driver support Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 01/21] mfd: uniphier: add UniPhier MFD driver Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 11:26 ` Lee Jones
2016-05-10 11:26 ` Lee Jones
2016-05-11 1:51 ` Masahiro Yamada
2016-05-11 1:51 ` Masahiro Yamada
2016-05-11 7:38 ` Lee Jones [this message]
2016-05-11 7:38 ` Lee Jones
2016-05-10 9:50 ` [RFC PATCH 02/21] clk: uniphier: add core support for UniPhier clock driver Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 03/21] clk: uniphier: add clock driver for UniPhier PH1-LD4 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 04/21] clk: uniphier: add clock driver for UniPhier PH1-Pro4 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 05/21] clk: uniphier: add clock driver for UniPhier PH1-sLD8 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 06/21] clk: uniphier: add clock driver for UniPhier PH1-Pro5 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 07/21] clk: uniphier: add clock driver for UniPhier ProXstream2/PH1-LD6b SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 08/21] clk: uniphier: add clock driver for UniPhier PH1-LD11 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 09/21] clk: uniphier: add clock driver for UniPhier PH1-LD20 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 10/21] clk: uniphier: add clock driver for Media I/O block on UniPhier SoCs Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 11/21] clk: uniphier: add clock driver for Peripheral " Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 12/21] reset: uniphier: add core support for UniPhier reset driver Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 13:54 ` Philipp Zabel
2016-05-10 13:54 ` Philipp Zabel
2016-05-11 2:46 ` Masahiro Yamada
2016-05-11 2:46 ` Masahiro Yamada
2016-05-11 10:34 ` Philipp Zabel
2016-05-11 10:34 ` Philipp Zabel
2016-05-10 9:50 ` [RFC PATCH 13/21] reset: uniphier: add reset driver for UniPhier PH1-LD4 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 12:25 ` Philipp Zabel
2016-05-10 12:25 ` Philipp Zabel
2016-05-11 2:52 ` Masahiro Yamada
2016-05-11 2:52 ` Masahiro Yamada
2016-05-11 10:34 ` Philipp Zabel
2016-05-11 10:34 ` Philipp Zabel
2016-05-11 10:37 ` Philipp Zabel
2016-05-11 10:37 ` Philipp Zabel
2016-05-10 9:50 ` [RFC PATCH 14/21] reset: uniphier: add reset driver for UniPhier PH1-Pro4 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 15/21] reset: uniphier: add reset driver for UniPhier PH1-sLD8 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 16/21] reset: uniphier: add reset driver for UniPhier PH1-Pro5 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 17/21] reset: uniphier: add reset driver for UniPhier ProXstream2/PH1-LD6b SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:50 ` [RFC PATCH 18/21] reset: uniphier: add reset driver for UniPhier PH1-LD11 SoC Masahiro Yamada
2016-05-10 9:50 ` Masahiro Yamada
2016-05-10 9:51 ` [RFC PATCH 19/21] reset: uniphier: add reset driver for UniPhier PH1-LD20 SoC Masahiro Yamada
2016-05-10 9:51 ` Masahiro Yamada
2016-05-10 9:51 ` Masahiro Yamada
2016-05-10 9:51 ` [RFC PATCH 20/21] reset: uniphier: add reset driver for Media I/O block on UniPhier SoCs Masahiro Yamada
2016-05-10 9:51 ` Masahiro Yamada
2016-05-10 9:51 ` [RFC PATCH 21/21] reset: uniphier: add reset driver for Peripheral " Masahiro Yamada
2016-05-10 9:51 ` Masahiro Yamada
2016-05-10 9:51 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511073855.GQ19473@dell \
--to=lee.jones@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@osg.samsung.com \
--cc=p.zabel@pengutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.