From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str
Date: Wed, 11 May 2016 10:40:57 +0100 [thread overview]
Message-ID: <20160511094057.GE26564@arm.com> (raw)
In-Reply-To: <5732FD9C.8000503@arm.com>
On Wed, May 11, 2016 at 10:38:36AM +0100, Julien Grall wrote:
> Hi Mark,
>
> On 10/05/2016 15:54, Mark Rutland wrote:
> >On Tue, May 10, 2016 at 03:40:31PM +0100, Julien Grall wrote:
> >>The loop that browses the array compat_hwcap_str will stop when a NULL
> >>is encountered, however NULL is missing at the end of array. This will
> >>result to overrun until one NULL is found somewhere in the memory.
> >
> >Probably worth adding something like:
> >
> >Note for backporting: commit 12d11817eaafa414 ("arm64: Move
> >/proc/cpuinfo handling code") moved this code. Prior to that commit, the
> >same change should be made in arch/arm64/kernel/setup.c.
>
> I can resend the patch with this changes.
No need, I've already applied it locally with Mark's suggestions.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
stable@vger.kernel.org,
"Suzuki K. Poulose" <suzuki.poulose@arm.com>
Subject: Re: [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str
Date: Wed, 11 May 2016 10:40:57 +0100 [thread overview]
Message-ID: <20160511094057.GE26564@arm.com> (raw)
In-Reply-To: <5732FD9C.8000503@arm.com>
On Wed, May 11, 2016 at 10:38:36AM +0100, Julien Grall wrote:
> Hi Mark,
>
> On 10/05/2016 15:54, Mark Rutland wrote:
> >On Tue, May 10, 2016 at 03:40:31PM +0100, Julien Grall wrote:
> >>The loop that browses the array compat_hwcap_str will stop when a NULL
> >>is encountered, however NULL is missing at the end of array. This will
> >>result to overrun until one NULL is found somewhere in the memory.
> >
> >Probably worth adding something like:
> >
> >Note for backporting: commit 12d11817eaafa414 ("arm64: Move
> >/proc/cpuinfo handling code") moved this code. Prior to that commit, the
> >same change should be made in arch/arm64/kernel/setup.c.
>
> I can resend the patch with this changes.
No need, I've already applied it locally with Mark's suggestions.
Will
next prev parent reply other threads:[~2016-05-11 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 14:40 [PATCH] arm64: cpuinfo: Missing NULL terminator in compat_hwcap_str Julien Grall
2016-05-10 14:40 ` Julien Grall
2016-05-10 14:54 ` Mark Rutland
2016-05-10 14:54 ` Mark Rutland
2016-05-11 9:38 ` Julien Grall
2016-05-11 9:38 ` Julien Grall
2016-05-11 9:40 ` Will Deacon [this message]
2016-05-11 9:40 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511094057.GE26564@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.