All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx6ul: Fix Micrel PHY mask
Date: Wed, 11 May 2016 21:50:14 +0200	[thread overview]
Message-ID: <20160511195014.GA17613@lunn.ch> (raw)
In-Reply-To: <1462995570-31055-1-git-send-email-festevam@gmail.com>

On Wed, May 11, 2016 at 04:39:30PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The value used for Micrel PHY mask is not correct. Use the 
> MICREL_PHY_ID_MASK definition instead.
> 
> Thanks to Jiri Luznicky for proposing the fix at
> https://community.freescale.com/thread/387739
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

It would be nice if drivers/net/phy/micrel.c was to use
MICREL_PHY_ID_MASK. But that is a different patch.

Thanks
	Andrew		    

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: shawnguo@kernel.org, Fabio Estevam <fabio.estevam@nxp.com>,
	fugang.duan@nxp.com, stable@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: imx6ul: Fix Micrel PHY mask
Date: Wed, 11 May 2016 21:50:14 +0200	[thread overview]
Message-ID: <20160511195014.GA17613@lunn.ch> (raw)
In-Reply-To: <1462995570-31055-1-git-send-email-festevam@gmail.com>

On Wed, May 11, 2016 at 04:39:30PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The value used for Micrel PHY mask is not correct. Use the 
> MICREL_PHY_ID_MASK definition instead.
> 
> Thanks to Jiri Luznicky for proposing the fix at
> https://community.freescale.com/thread/387739
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

It would be nice if drivers/net/phy/micrel.c was to use
MICREL_PHY_ID_MASK. But that is a different patch.

Thanks
	Andrew		    

  reply	other threads:[~2016-05-11 19:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 19:39 [PATCH] ARM: imx6ul: Fix Micrel PHY mask Fabio Estevam
2016-05-11 19:39 ` Fabio Estevam
2016-05-11 19:50 ` Andrew Lunn [this message]
2016-05-11 19:50   ` Andrew Lunn
2016-05-11 19:53   ` Fabio Estevam
2016-05-11 19:53     ` Fabio Estevam
2016-06-09 12:50 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160511195014.GA17613@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.