* [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()
@ 2016-05-12 13:43 Paul Durrant
2016-05-12 14:15 ` Wei Liu
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Paul Durrant @ 2016-05-12 13:43 UTC (permalink / raw)
To: xen-devel, netdev; +Cc: Paul Durrant, Wei Liu
Patch 562abd39 "xen-netback: support multiple extra info fragments
passed from frontend" contained a mistake which can result in an in-
correct number of responses being generated when handling errors
encountered when processing packets containing extra info fragments.
This patch fixes the problem.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Reported-by: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
drivers/net/xen-netback/netback.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index b42f260..4412a57 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -711,6 +711,7 @@ static void xenvif_tx_err(struct xenvif_queue *queue,
if (cons == end)
break;
RING_COPY_REQUEST(&queue->tx, cons++, txp);
+ extra_count = 0; /* only the first frag can have extras */
} while (1);
queue->tx.req_cons = cons;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()
2016-05-12 13:43 [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err() Paul Durrant
@ 2016-05-12 14:15 ` Wei Liu
2016-05-12 14:15 ` Wei Liu
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2016-05-12 14:15 UTC (permalink / raw)
To: Paul Durrant; +Cc: xen-devel, netdev, Wei Liu
On Thu, May 12, 2016 at 02:43:03PM +0100, Paul Durrant wrote:
> Patch 562abd39 "xen-netback: support multiple extra info fragments
> passed from frontend" contained a mistake which can result in an in-
> correct number of responses being generated when handling errors
> encountered when processing packets containing extra info fragments.
> This patch fixes the problem.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Reported-by: Jan Beulich <JBeulich@suse.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> drivers/net/xen-netback/netback.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index b42f260..4412a57 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -711,6 +711,7 @@ static void xenvif_tx_err(struct xenvif_queue *queue,
> if (cons == end)
> break;
> RING_COPY_REQUEST(&queue->tx, cons++, txp);
> + extra_count = 0; /* only the first frag can have extras */
> } while (1);
> queue->tx.req_cons = cons;
> }
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()
2016-05-12 13:43 [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err() Paul Durrant
2016-05-12 14:15 ` Wei Liu
@ 2016-05-12 14:15 ` Wei Liu
2016-05-13 5:59 ` David Miller
2016-05-13 5:59 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2016-05-12 14:15 UTC (permalink / raw)
To: Paul Durrant; +Cc: xen-devel, Wei Liu, netdev
On Thu, May 12, 2016 at 02:43:03PM +0100, Paul Durrant wrote:
> Patch 562abd39 "xen-netback: support multiple extra info fragments
> passed from frontend" contained a mistake which can result in an in-
> correct number of responses being generated when handling errors
> encountered when processing packets containing extra info fragments.
> This patch fixes the problem.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Reported-by: Jan Beulich <JBeulich@suse.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> drivers/net/xen-netback/netback.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index b42f260..4412a57 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -711,6 +711,7 @@ static void xenvif_tx_err(struct xenvif_queue *queue,
> if (cons == end)
> break;
> RING_COPY_REQUEST(&queue->tx, cons++, txp);
> + extra_count = 0; /* only the first frag can have extras */
> } while (1);
> queue->tx.req_cons = cons;
> }
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()
2016-05-12 13:43 [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err() Paul Durrant
2016-05-12 14:15 ` Wei Liu
2016-05-12 14:15 ` Wei Liu
@ 2016-05-13 5:59 ` David Miller
2016-05-13 5:59 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-05-13 5:59 UTC (permalink / raw)
To: paul.durrant; +Cc: xen-devel, wei.liu2, netdev
From: Paul Durrant <paul.durrant@citrix.com>
Date: Thu, 12 May 2016 14:43:03 +0100
> Patch 562abd39 "xen-netback: support multiple extra info fragments
> passed from frontend" contained a mistake which can result in an in-
> correct number of responses being generated when handling errors
> encountered when processing packets containing extra info fragments.
> This patch fixes the problem.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Reported-by: Jan Beulich <JBeulich@suse.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()
2016-05-12 13:43 [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err() Paul Durrant
` (2 preceding siblings ...)
2016-05-13 5:59 ` David Miller
@ 2016-05-13 5:59 ` David Miller
3 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-05-13 5:59 UTC (permalink / raw)
To: paul.durrant; +Cc: xen-devel, netdev, wei.liu2
From: Paul Durrant <paul.durrant@citrix.com>
Date: Thu, 12 May 2016 14:43:03 +0100
> Patch 562abd39 "xen-netback: support multiple extra info fragments
> passed from frontend" contained a mistake which can result in an in-
> correct number of responses being generated when handling errors
> encountered when processing packets containing extra info fragments.
> This patch fixes the problem.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> Reported-by: Jan Beulich <JBeulich@suse.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()
@ 2016-05-12 13:43 Paul Durrant
0 siblings, 0 replies; 6+ messages in thread
From: Paul Durrant @ 2016-05-12 13:43 UTC (permalink / raw)
To: xen-devel, netdev; +Cc: Paul Durrant, Wei Liu
Patch 562abd39 "xen-netback: support multiple extra info fragments
passed from frontend" contained a mistake which can result in an in-
correct number of responses being generated when handling errors
encountered when processing packets containing extra info fragments.
This patch fixes the problem.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Reported-by: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
drivers/net/xen-netback/netback.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index b42f260..4412a57 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -711,6 +711,7 @@ static void xenvif_tx_err(struct xenvif_queue *queue,
if (cons == end)
break;
RING_COPY_REQUEST(&queue->tx, cons++, txp);
+ extra_count = 0; /* only the first frag can have extras */
} while (1);
queue->tx.req_cons = cons;
}
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-13 5:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-12 13:43 [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err() Paul Durrant
2016-05-12 14:15 ` Wei Liu
2016-05-12 14:15 ` Wei Liu
2016-05-13 5:59 ` David Miller
2016-05-13 5:59 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-05-12 13:43 Paul Durrant
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.