From: Omar Sandoval <osandov-nWWhXC5lh1RBDgjK7y7TUQ@public.gmane.org>
To: Florian Weimer <fweimer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Michael Kerrisk
<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Omar Sandoval <osandov-b10kYP2dOMg@public.gmane.org>
Subject: Re: [PATCH 1/2] mount.2: document MS_REC and shared subtree flags
Date: Thu, 12 May 2016 10:58:48 -0700 [thread overview]
Message-ID: <20160512175848.GA19948@vader> (raw)
In-Reply-To: <57344070.3020603-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Thu, May 12, 2016 at 10:36:00AM +0200, Florian Weimer wrote:
> On 05/12/2016 09:17 AM, Omar Sandoval wrote:
> > +.BR MS_PRIVATE " (since Linux 2.6.15)"
> > +Set the mount propagation on this mountpoint to private. Mounts will not
> > +propagate to or from replicated subtrees.
> > +When used, this must be the only flag in
> > +.IR mountflags .
>
> Is the last sentence actually true? Further down, your patch mentions
> combining MS_PRIVATE with other flags.
>
> Thanks,
> Florian
Yeah, you're right, I documented that it can be combined with MS_REC,
and looking closer, it can also be combined with MS_SILENT. Even more
confusing is that there's a bunch of flags that we'll end up ignoring:
flags &= ~(MS_NOSUID | MS_NOEXEC | MS_NODEV | MS_ACTIVE | MS_BORN |
MS_NOATIME | MS_NODIRATIME | MS_RELATIME| MS_KERNMOUNT |
MS_STRICTATIME);
So any of those flags are ignored, MS_REC and MS_SILENT are valid, and
anything else is an error. I'll try to come up with an explanation that
makes sense, but it's a bit of a mess.
--
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Omar Sandoval <osandov@osandov.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH 1/2] mount.2: document MS_REC and shared subtree flags
Date: Thu, 12 May 2016 10:58:48 -0700 [thread overview]
Message-ID: <20160512175848.GA19948@vader> (raw)
In-Reply-To: <57344070.3020603@redhat.com>
On Thu, May 12, 2016 at 10:36:00AM +0200, Florian Weimer wrote:
> On 05/12/2016 09:17 AM, Omar Sandoval wrote:
> > +.BR MS_PRIVATE " (since Linux 2.6.15)"
> > +Set the mount propagation on this mountpoint to private. Mounts will not
> > +propagate to or from replicated subtrees.
> > +When used, this must be the only flag in
> > +.IR mountflags .
>
> Is the last sentence actually true? Further down, your patch mentions
> combining MS_PRIVATE with other flags.
>
> Thanks,
> Florian
Yeah, you're right, I documented that it can be combined with MS_REC,
and looking closer, it can also be combined with MS_SILENT. Even more
confusing is that there's a bunch of flags that we'll end up ignoring:
flags &= ~(MS_NOSUID | MS_NOEXEC | MS_NODEV | MS_ACTIVE | MS_BORN |
MS_NOATIME | MS_NODIRATIME | MS_RELATIME| MS_KERNMOUNT |
MS_STRICTATIME);
So any of those flags are ignored, MS_REC and MS_SILENT are valid, and
anything else is an error. I'll try to come up with an explanation that
makes sense, but it's a bit of a mess.
--
Omar
next prev parent reply other threads:[~2016-05-12 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 7:17 [PATCH 1/2] mount.2: document MS_REC and shared subtree flags Omar Sandoval
2016-05-12 7:17 ` Omar Sandoval
2016-05-12 7:17 ` [PATCH 2/2] mount.2: MS_BIND still ignores mountflags Omar Sandoval
2016-05-12 8:36 ` [PATCH 1/2] mount.2: document MS_REC and shared subtree flags Florian Weimer
[not found] ` <57344070.3020603-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-12 17:58 ` Omar Sandoval [this message]
2016-05-12 17:58 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512175848.GA19948@vader \
--to=osandov-nwwhxc5lh1rbdgjk7y7tuq@public.gmane.org \
--cc=fweimer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=osandov-b10kYP2dOMg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.