From: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
ZhengShunQian <zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] iommu/rockchip: fix zap cache during device attach
Date: Sun, 15 May 2016 12:16:39 +0100 [thread overview]
Message-ID: <20160515111638.GA9715@river> (raw)
In-Reply-To: <11003810.ccjcAXkzhi@phil>
On Sat, May 14, 2016 at 10:19:43PM +0200, Heiko Stuebner wrote:
> Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping:
> > rk_iommu_command() takes a struct rk_iommu and iterates over the slave
> > MMUs, so this is doubly wrong in that we're passing in the wrong pointer
> > and talking to MMUs that we shouldn't be.
> >
> > Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi
> > slaves") Signed-off-by: John Keeping <john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
>
> on a rk3288-veyron
> Tested-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
>
> I was wondering for a short time why this didn't spew warnings until I
> realized that the iommu->bases[i] is of course a void* .
Yes, although sparse catches it because iommu->bases[i] is __iomem so it
shows up as a namespace warning.
WARNING: multiple messages have this Message-ID (diff)
From: john@metanate.com (John Keeping)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/rockchip: fix zap cache during device attach
Date: Sun, 15 May 2016 12:16:39 +0100 [thread overview]
Message-ID: <20160515111638.GA9715@river> (raw)
In-Reply-To: <11003810.ccjcAXkzhi@phil>
On Sat, May 14, 2016 at 10:19:43PM +0200, Heiko Stuebner wrote:
> Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping:
> > rk_iommu_command() takes a struct rk_iommu and iterates over the slave
> > MMUs, so this is doubly wrong in that we're passing in the wrong pointer
> > and talking to MMUs that we shouldn't be.
> >
> > Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi
> > slaves") Signed-off-by: John Keeping <john@metanate.com>
>
> on a rk3288-veyron
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> I was wondering for a short time why this didn't spew warnings until I
> realized that the iommu->bases[i] is of course a void* .
Yes, although sparse catches it because iommu->bases[i] is __iomem so it
shows up as a namespace warning.
WARNING: multiple messages have this Message-ID (diff)
From: John Keeping <john@metanate.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
ZhengShunQian <zhengsq@rock-chips.com>
Subject: Re: [PATCH] iommu/rockchip: fix zap cache during device attach
Date: Sun, 15 May 2016 12:16:39 +0100 [thread overview]
Message-ID: <20160515111638.GA9715@river> (raw)
In-Reply-To: <11003810.ccjcAXkzhi@phil>
On Sat, May 14, 2016 at 10:19:43PM +0200, Heiko Stuebner wrote:
> Am Dienstag, 10. Mai 2016, 16:50:46 schrieb John Keeping:
> > rk_iommu_command() takes a struct rk_iommu and iterates over the slave
> > MMUs, so this is doubly wrong in that we're passing in the wrong pointer
> > and talking to MMUs that we shouldn't be.
> >
> > Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi
> > slaves") Signed-off-by: John Keeping <john@metanate.com>
>
> on a rk3288-veyron
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> I was wondering for a short time why this didn't spew warnings until I
> realized that the iommu->bases[i] is of course a void* .
Yes, although sparse catches it because iommu->bases[i] is __iomem so it
shows up as a namespace warning.
next prev parent reply other threads:[~2016-05-15 11:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 15:50 [PATCH] iommu/rockchip: fix zap cache during device attach John Keeping
2016-05-10 15:50 ` John Keeping
2016-05-10 15:50 ` John Keeping
[not found] ` <20160510155046.24515-1-john-HooS5bfzL4hWk0Htik3J/w@public.gmane.org>
2016-05-14 20:19 ` Heiko Stuebner
2016-05-14 20:19 ` Heiko Stuebner
2016-05-14 20:19 ` Heiko Stuebner
2016-05-15 11:16 ` John Keeping [this message]
2016-05-15 11:16 ` John Keeping
2016-05-15 11:16 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160515111638.GA9715@river \
--to=john-hoos5bfzl4hwk0htik3j/w@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.