All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Rabin Vincent <rabin@rab.in>
Cc: Rabin Vincent <rabin.vincent@axis.com>,
	"David S. Miller" <davem@davemloft.net>,
	f.fainelli@gmail.com, netdev@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org,
	devicetree@vger.kernel.org, Rabin Vincent <rabinv@axis.com>
Subject: Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()
Date: Mon, 16 May 2016 15:40:42 +0200	[thread overview]
Message-ID: <20160516134042.GD27725@lunn.ch> (raw)
In-Reply-To: <20160516131134.GA31094@lnxartpec.se.axis.com>

On Mon, May 16, 2016 at 03:11:35PM +0200, Rabin Vincent wrote:
> On Mon, May 16, 2016 at 02:29:03PM +0200, Andrew Lunn wrote:
> > What i think is better is to make fixed_phy_add() return -EPROBE_DEFER
> > if it is called before fixed_mdio_bus_init().
> 
> I don't see how this will work for platforms such as ar7 and bcm47xx
> which call fixed_phy_add() from platform code.

Ah! Not good.

fixed_phy_add() is the lower layer call. What we can do is only access
fmb->mii_bus->irq[phy_addr] if irq != PHY_POLL. That should make ar7
and bcm47xx work again.

The higher level function fixed_phy_register() should return
-EPROBE_DEFER if fixed_mdio_bus_init() has not been called yet.

Thanks
	Andrew

  reply	other threads:[~2016-05-16 13:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-16 11:15 [PATCH] phy: remove irq param to fix crash in fixed_phy_add() Rabin Vincent
2016-05-16 12:29 ` Andrew Lunn
2016-05-16 13:11   ` Rabin Vincent
2016-05-16 13:11   ` Rabin Vincent
2016-05-16 13:11     ` Rabin Vincent
2016-05-16 13:40     ` Andrew Lunn [this message]
2016-05-16 17:26       ` Florian Fainelli
2016-05-16 13:40     ` Andrew Lunn
2016-05-17 18:20 ` David Miller
2016-05-17 18:20 ` David Miller
2016-05-17 18:27   ` Florian Fainelli
2016-05-17 18:30     ` David Miller
2016-05-17 18:27   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160516134042.GD27725@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mips@linux-mips.org \
    --cc=netdev@vger.kernel.org \
    --cc=rabin.vincent@axis.com \
    --cc=rabin@rab.in \
    --cc=rabinv@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.