From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, rabin.vincent@axis.com
Cc: andrew@lunn.ch, netdev@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org,
devicetree@vger.kernel.org, rabinv@axis.com
Subject: Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()
Date: Tue, 17 May 2016 11:27:12 -0700 [thread overview]
Message-ID: <573B6280.3030405@gmail.com> (raw)
In-Reply-To: <20160517.142034.611823602956859056.davem@davemloft.net>
On 05/17/2016 11:20 AM, David Miller wrote:
> From: Rabin Vincent <rabin.vincent@axis.com>
> Date: Mon, 16 May 2016 13:15:56 +0200
>
>> From: Rabin Vincent <rabinv@axis.com>
>>
>> Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"),
>> platforms which call fixed_phy_add() before fixed_mdio_bus_init() is
>> called (for example, because the platform code and the fixed_phy driver
>> use the same initcall level) crash in fixed_phy_add() since the
>> ->mii_bus is not allocated.
>>
>> Also since e7f4dc3536a, these interrupts are initalized to polling by
>> default. All callers of both fixed_phy_register() and fixed_phy_add()
>> pass PHY_POLL for the irq argument, so we can fix these crashes by
>> simply removing the irq parameter, since the default is correct for all
>> users.
>>
>> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
>> Signed-off-by: Rabin Vincent <rabinv@axis.com>
>
> Applied.
David, there was a v2 sent just earlier this morning here:
http://patchwork.ozlabs.org/patch/622967/
which was appropriately marked with Changes Requested, so why would we
apply v1?
--
Florian
next prev parent reply other threads:[~2016-05-17 18:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 11:15 [PATCH] phy: remove irq param to fix crash in fixed_phy_add() Rabin Vincent
2016-05-16 12:29 ` Andrew Lunn
2016-05-16 13:11 ` Rabin Vincent
2016-05-16 13:11 ` Rabin Vincent
2016-05-16 13:40 ` Andrew Lunn
2016-05-16 13:40 ` Andrew Lunn
2016-05-16 17:26 ` Florian Fainelli
2016-05-16 13:11 ` Rabin Vincent
2016-05-17 18:20 ` David Miller
2016-05-17 18:20 ` David Miller
2016-05-17 18:27 ` Florian Fainelli [this message]
2016-05-17 18:30 ` David Miller
2016-05-17 18:27 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573B6280.3030405@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=rabin.vincent@axis.com \
--cc=rabinv@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.