* [patch] iio: humidity: Remove a stray unlock
@ 2016-05-17 7:31 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2016-05-17 7:31 UTC (permalink / raw)
To: Jonathan Cameron, Tiberiu Breana
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
We haven't taken the lock yet so we don't need to unlock here.
Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for AM2315')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
index 3be6d20..1153591 100644
--- a/drivers/iio/humidity/am2315.c
+++ b/drivers/iio/humidity/am2315.c
@@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p)
struct am2315_sensor_data sensor_data;
ret = am2315_read_data(data, &sensor_data);
- if (ret < 0) {
- mutex_unlock(&data->lock);
+ if (ret < 0)
goto err;
- }
mutex_lock(&data->lock);
if (*(indio_dev->active_scan_mask) = AM2315_ALL_CHANNEL_MASK) {
^ permalink raw reply related [flat|nested] 10+ messages in thread* [patch] iio: humidity: Remove a stray unlock
@ 2016-05-17 7:31 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2016-05-17 7:31 UTC (permalink / raw)
To: Jonathan Cameron, Tiberiu Breana
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
We haven't taken the lock yet so we don't need to unlock here.
Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for AM2315')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
index 3be6d20..1153591 100644
--- a/drivers/iio/humidity/am2315.c
+++ b/drivers/iio/humidity/am2315.c
@@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p)
struct am2315_sensor_data sensor_data;
ret = am2315_read_data(data, &sensor_data);
- if (ret < 0) {
- mutex_unlock(&data->lock);
+ if (ret < 0)
goto err;
- }
mutex_lock(&data->lock);
if (*(indio_dev->active_scan_mask) == AM2315_ALL_CHANNEL_MASK) {
^ permalink raw reply related [flat|nested] 10+ messages in thread* RE: [patch] iio: humidity: Remove a stray unlock
2016-05-17 7:31 ` Dan Carpenter
@ 2016-05-17 7:43 ` Breana, Tiberiu A
-1 siblings, 0 replies; 10+ messages in thread
From: Breana, Tiberiu A @ 2016-05-17 7:43 UTC (permalink / raw)
To: Dan Carpenter, Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Tuesday, May 17, 2016 10:32 AM
> To: Jonathan Cameron <jic23@kernel.org>; Breana, Tiberiu A
> <tiberiu.a.breana@intel.com>
> Cc: Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen
> <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>;
> linux-iio@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] iio: humidity: Remove a stray unlock
>
> We haven't taken the lock yet so we don't need to unlock here.
>
> Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for
> AM2315')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
> index 3be6d20..1153591 100644
> --- a/drivers/iio/humidity/am2315.c
> +++ b/drivers/iio/humidity/am2315.c
> @@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq,
> void *p)
> struct am2315_sensor_data sensor_data;
>
> ret = am2315_read_data(data, &sensor_data);
> - if (ret < 0) {
> - mutex_unlock(&data->lock);
> + if (ret < 0)
> goto err;
> - }
>
> mutex_lock(&data->lock);
> if (*(indio_dev->active_scan_mask) =
> AM2315_ALL_CHANNEL_MASK) {
That one must have slipped by during development versions.
You might also want to add am2315 in the patch title.
Thanks,
Acked-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [patch] iio: humidity: Remove a stray unlock
@ 2016-05-17 7:43 ` Breana, Tiberiu A
0 siblings, 0 replies; 10+ messages in thread
From: Breana, Tiberiu A @ 2016-05-17 7:43 UTC (permalink / raw)
To: Dan Carpenter, Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Tuesday, May 17, 2016 10:32 AM
> To: Jonathan Cameron <jic23@kernel.org>; Breana, Tiberiu A
> <tiberiu.a.breana@intel.com>
> Cc: Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen
> <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>;
> linux-iio@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [patch] iio: humidity: Remove a stray unlock
>=20
> We haven't taken the lock yet so we don't need to unlock here.
>=20
> Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for
> AM2315')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>=20
> diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.=
c
> index 3be6d20..1153591 100644
> --- a/drivers/iio/humidity/am2315.c
> +++ b/drivers/iio/humidity/am2315.c
> @@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq,
> void *p)
> struct am2315_sensor_data sensor_data;
>=20
> ret =3D am2315_read_data(data, &sensor_data);
> - if (ret < 0) {
> - mutex_unlock(&data->lock);
> + if (ret < 0)
> goto err;
> - }
>=20
> mutex_lock(&data->lock);
> if (*(indio_dev->active_scan_mask) =3D=3D
> AM2315_ALL_CHANNEL_MASK) {
That one must have slipped by during development versions.
You might also want to add am2315 in the patch title.
Thanks,
Acked-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [patch] iio: humidity: Remove a stray unlock
2016-05-17 7:43 ` Breana, Tiberiu A
@ 2016-05-17 8:00 ` Dan Carpenter
-1 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2016-05-17 8:00 UTC (permalink / raw)
To: Breana, Tiberiu A
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-iio@vger.kernel.org,
kernel-janitors@vger.kernel.org
On Tue, May 17, 2016 at 07:43:21AM +0000, Breana, Tiberiu A wrote:
> That one must have slipped by during development versions.
> You might also want to add am2315 in the patch title.
Yeah. I'll resend.
I obviously just mindlessly cut and pasted that from the earlier patch:
Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for AM2315')
That patch also has the wrong subject line because it was just copied
from the first patch 366a3270c1c5 ('iio: humidity: Add support for
AM2315').
And just a few minutes ago I was giving another new driver its own
prefix. But even though I thought--more than I should have--about
what the author wanted to use as a prefix for his driver, I still
probably read his mind incorrectly.
In other words, we need to start with the correct prefix from square
one: iio: humidity: am2315: Add support for AM2315
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [patch] iio: humidity: Remove a stray unlock
@ 2016-05-17 8:00 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2016-05-17 8:00 UTC (permalink / raw)
To: Breana, Tiberiu A
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-iio@vger.kernel.org,
kernel-janitors@vger.kernel.org
On Tue, May 17, 2016 at 07:43:21AM +0000, Breana, Tiberiu A wrote:
> That one must have slipped by during development versions.
> You might also want to add am2315 in the patch title.
Yeah. I'll resend.
I obviously just mindlessly cut and pasted that from the earlier patch:
Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for AM2315')
That patch also has the wrong subject line because it was just copied
from the first patch 366a3270c1c5 ('iio: humidity: Add support for
AM2315').
And just a few minutes ago I was giving another new driver its own
prefix. But even though I thought--more than I should have--about
what the author wanted to use as a prefix for his driver, I still
probably read his mind incorrectly.
In other words, we need to start with the correct prefix from square
one: iio: humidity: am2315: Add support for AM2315
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* [patch v2] iio: humidity: am2315: Remove a stray unlock
2016-05-17 7:43 ` Breana, Tiberiu A
@ 2016-05-17 8:02 ` Dan Carpenter
-1 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2016-05-17 8:02 UTC (permalink / raw)
To: Jonathan Cameron, Tiberiu Breana
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
We haven't taken the lock yet so we don't need to unlock here.
Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for AM2315')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
---
v2: update subject
diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
index 3be6d20..1153591 100644
--- a/drivers/iio/humidity/am2315.c
+++ b/drivers/iio/humidity/am2315.c
@@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p)
struct am2315_sensor_data sensor_data;
ret = am2315_read_data(data, &sensor_data);
- if (ret < 0) {
- mutex_unlock(&data->lock);
+ if (ret < 0)
goto err;
- }
mutex_lock(&data->lock);
if (*(indio_dev->active_scan_mask) = AM2315_ALL_CHANNEL_MASK) {
^ permalink raw reply related [flat|nested] 10+ messages in thread* [patch v2] iio: humidity: am2315: Remove a stray unlock
@ 2016-05-17 8:02 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2016-05-17 8:02 UTC (permalink / raw)
To: Jonathan Cameron, Tiberiu Breana
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
We haven't taken the lock yet so we don't need to unlock here.
Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for AM2315')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
---
v2: update subject
diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
index 3be6d20..1153591 100644
--- a/drivers/iio/humidity/am2315.c
+++ b/drivers/iio/humidity/am2315.c
@@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p)
struct am2315_sensor_data sensor_data;
ret = am2315_read_data(data, &sensor_data);
- if (ret < 0) {
- mutex_unlock(&data->lock);
+ if (ret < 0)
goto err;
- }
mutex_lock(&data->lock);
if (*(indio_dev->active_scan_mask) == AM2315_ALL_CHANNEL_MASK) {
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [patch v2] iio: humidity: am2315: Remove a stray unlock
2016-05-17 8:02 ` Dan Carpenter
@ 2016-05-21 16:48 ` Jonathan Cameron
-1 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2016-05-21 16:48 UTC (permalink / raw)
To: Dan Carpenter, Tiberiu Breana
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
On 17/05/16 09:02, Dan Carpenter wrote:
> We haven't taken the lock yet so we don't need to unlock here.
>
> Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for AM2315')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git
Thanks,
Jonathan
> ---
> v2: update subject
>
> diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
> index 3be6d20..1153591 100644
> --- a/drivers/iio/humidity/am2315.c
> +++ b/drivers/iio/humidity/am2315.c
> @@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p)
> struct am2315_sensor_data sensor_data;
>
> ret = am2315_read_data(data, &sensor_data);
> - if (ret < 0) {
> - mutex_unlock(&data->lock);
> + if (ret < 0)
> goto err;
> - }
>
> mutex_lock(&data->lock);
> if (*(indio_dev->active_scan_mask) = AM2315_ALL_CHANNEL_MASK) {
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [patch v2] iio: humidity: am2315: Remove a stray unlock
@ 2016-05-21 16:48 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2016-05-21 16:48 UTC (permalink / raw)
To: Dan Carpenter, Tiberiu Breana
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, kernel-janitors
On 17/05/16 09:02, Dan Carpenter wrote:
> We haven't taken the lock yet so we don't need to unlock here.
>
> Fixes: 0d96d5ead3f7 ('iio: humidity: Add triggered buffer support for AM2315')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git
Thanks,
Jonathan
> ---
> v2: update subject
>
> diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
> index 3be6d20..1153591 100644
> --- a/drivers/iio/humidity/am2315.c
> +++ b/drivers/iio/humidity/am2315.c
> @@ -165,10 +165,8 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p)
> struct am2315_sensor_data sensor_data;
>
> ret = am2315_read_data(data, &sensor_data);
> - if (ret < 0) {
> - mutex_unlock(&data->lock);
> + if (ret < 0)
> goto err;
> - }
>
> mutex_lock(&data->lock);
> if (*(indio_dev->active_scan_mask) == AM2315_ALL_CHANNEL_MASK) {
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-05-21 16:48 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-17 7:31 [patch] iio: humidity: Remove a stray unlock Dan Carpenter
2016-05-17 7:31 ` Dan Carpenter
2016-05-17 7:43 ` Breana, Tiberiu A
2016-05-17 7:43 ` Breana, Tiberiu A
2016-05-17 8:00 ` Dan Carpenter
2016-05-17 8:00 ` Dan Carpenter
2016-05-17 8:02 ` [patch v2] iio: humidity: am2315: " Dan Carpenter
2016-05-17 8:02 ` Dan Carpenter
2016-05-21 16:48 ` Jonathan Cameron
2016-05-21 16:48 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.