From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/1] userfaultfd: don't pin the user memory in userfaultfd_file_create()
Date: Tue, 17 May 2016 18:30:44 +0200 [thread overview]
Message-ID: <20160517163044.GA31867@redhat.com> (raw)
In-Reply-To: <20160517153302.GE14446@dhcp22.suse.cz>
On 05/17, Michal Hocko wrote:
>
> On Mon 16-05-16 19:22:54, Oleg Nesterov wrote:
>
> > The patch adds the new trivial helper, mmget_not_zero(), it can have more users.
>
> Is this really helpful?
Well, this is subjective of course, but I think the code looks a bit better this
way. uprobes, fs/proc and more can use this helper too.
And in fact the initial version of this patch did atomic_inc_not_zero(mm->users) by
hand, then it was suggested to add a helper.
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> The patch seems good to me but I am not familiar with the userfaultfd
> internals enought to give you reviewed-by nor acked-by. I welcome the
> change anyway.
Thanks ;)
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/1] userfaultfd: don't pin the user memory in userfaultfd_file_create()
Date: Tue, 17 May 2016 18:30:44 +0200 [thread overview]
Message-ID: <20160517163044.GA31867@redhat.com> (raw)
In-Reply-To: <20160517153302.GE14446@dhcp22.suse.cz>
On 05/17, Michal Hocko wrote:
>
> On Mon 16-05-16 19:22:54, Oleg Nesterov wrote:
>
> > The patch adds the new trivial helper, mmget_not_zero(), it can have more users.
>
> Is this really helpful?
Well, this is subjective of course, but I think the code looks a bit better this
way. uprobes, fs/proc and more can use this helper too.
And in fact the initial version of this patch did atomic_inc_not_zero(mm->users) by
hand, then it was suggested to add a helper.
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> The patch seems good to me but I am not familiar with the userfaultfd
> internals enought to give you reviewed-by nor acked-by. I welcome the
> change anyway.
Thanks ;)
Oleg.
next prev parent reply other threads:[~2016-05-17 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 15:25 [PATCH 0/1] userfaultfd: don't pin the user memory in userfaultfd_file_create() Oleg Nesterov
2016-05-16 15:25 ` Oleg Nesterov
2016-05-16 15:25 ` [PATCH 1/1] " Oleg Nesterov
2016-05-16 15:25 ` Oleg Nesterov
2016-05-16 15:57 ` Andrea Arcangeli
2016-05-16 15:57 ` Andrea Arcangeli
2016-05-16 16:20 ` Oleg Nesterov
2016-05-16 16:20 ` Oleg Nesterov
2016-05-16 17:22 ` [PATCH v2 " Oleg Nesterov
2016-05-16 17:22 ` Oleg Nesterov
2016-05-17 15:33 ` Michal Hocko
2016-05-17 15:33 ` Michal Hocko
2016-05-17 16:30 ` Oleg Nesterov [this message]
2016-05-17 16:30 ` Oleg Nesterov
2016-05-17 20:34 ` Michal Hocko
2016-05-17 20:34 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517163044.GA31867@redhat.com \
--to=oleg@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.