All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: Intel: Skylake: Add channel constraints for refcap
@ 2016-05-17 16:43 Yong Zhi
  2016-05-17 16:43 ` [PATCH 2/2] ASoC: Intel: Skylake: Use refcap device for mono recording Yong Zhi
  2016-05-19  3:39 ` [PATCH 1/2] ASoC: Intel: Skylake: Add channel constraints for refcap Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Yong Zhi @ 2016-05-17 16:43 UTC (permalink / raw)
  To: broonie
  Cc: alsa-devel, benzh, vinod.koul, marc.herbert, yang.a.fang,
	sathya.prakash.m.r, jeeja.kp, vedang.patel, Yong Zhi

Add constraint for ref DMIC to match with the
topology firmware config.

Signed-off-by: Yong Zhi <yong.zhi@intel.com>
---
 sound/soc/intel/boards/skl_nau88l25_max98357a.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/sound/soc/intel/boards/skl_nau88l25_max98357a.c b/sound/soc/intel/boards/skl_nau88l25_max98357a.c
index 7cc7251..463f0e5 100644
--- a/sound/soc/intel/boards/skl_nau88l25_max98357a.c
+++ b/sound/soc/intel/boards/skl_nau88l25_max98357a.c
@@ -339,8 +339,22 @@ static struct snd_pcm_hw_constraint_list constraints_16000 = {
 	.list  = rates_16000,
 };
 
+static const unsigned int ch_mono[] = {
+	1,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_refcap = {
+	.count = ARRAY_SIZE(ch_mono),
+	.list  = ch_mono,
+};
+
 static int skylake_refcap_startup(struct snd_pcm_substream *substream)
 {
+	substream->runtime->hw.channels_max = 1;
+	snd_pcm_hw_constraint_list(substream->runtime, 0,
+					SNDRV_PCM_HW_PARAM_CHANNELS,
+					&constraints_refcap);
+
 	return snd_pcm_hw_constraint_list(substream->runtime, 0,
 				SNDRV_PCM_HW_PARAM_RATE,
 				&constraints_16000);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ASoC: Intel: Skylake: Use refcap device for mono recording
  2016-05-17 16:43 [PATCH 1/2] ASoC: Intel: Skylake: Add channel constraints for refcap Yong Zhi
@ 2016-05-17 16:43 ` Yong Zhi
  2016-05-19  3:39 ` [PATCH 1/2] ASoC: Intel: Skylake: Add channel constraints for refcap Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Yong Zhi @ 2016-05-17 16:43 UTC (permalink / raw)
  To: broonie
  Cc: alsa-devel, benzh, vinod.koul, marc.herbert, yang.a.fang,
	sathya.prakash.m.r, jeeja.kp, vedang.patel, Yong Zhi

Only mono channel is allowed for refcap device.

Signed-off-by: Yong Zhi <yong.zhi@intel.com>
---
 sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
index 73cbddb..65002bd 100644
--- a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
+++ b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c
@@ -388,8 +388,22 @@ static struct snd_pcm_hw_constraint_list constraints_16000 = {
 	.list  = rates_16000,
 };
 
+static const unsigned int ch_mono[] = {
+	1,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_refcap = {
+	.count = ARRAY_SIZE(ch_mono),
+	.list  = ch_mono,
+};
+
 static int skylake_refcap_startup(struct snd_pcm_substream *substream)
 {
+	substream->runtime->hw.channels_max = 1;
+	snd_pcm_hw_constraint_list(substream->runtime, 0,
+					SNDRV_PCM_HW_PARAM_CHANNELS,
+					&constraints_refcap);
+
 	return snd_pcm_hw_constraint_list(substream->runtime, 0,
 			SNDRV_PCM_HW_PARAM_RATE,
 			&constraints_16000);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: Intel: Skylake: Add channel constraints for refcap
  2016-05-17 16:43 [PATCH 1/2] ASoC: Intel: Skylake: Add channel constraints for refcap Yong Zhi
  2016-05-17 16:43 ` [PATCH 2/2] ASoC: Intel: Skylake: Use refcap device for mono recording Yong Zhi
@ 2016-05-19  3:39 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2016-05-19  3:39 UTC (permalink / raw)
  To: Yong Zhi
  Cc: alsa-devel, yang.a.fang, marc.herbert, benzh, broonie,
	sathya.prakash.m.r, jeeja.kp, vedang.patel

On Tue, May 17, 2016 at 09:43:04AM -0700, Yong Zhi wrote:
> Add constraint for ref DMIC to match with the
> topology firmware config.
> 
> Signed-off-by: Yong Zhi <yong.zhi@intel.com>

Both:

Acked-by: Vinod Koul <vinod.koul@intel.com>

> ---
>  sound/soc/intel/boards/skl_nau88l25_max98357a.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/skl_nau88l25_max98357a.c b/sound/soc/intel/boards/skl_nau88l25_max98357a.c
> index 7cc7251..463f0e5 100644
> --- a/sound/soc/intel/boards/skl_nau88l25_max98357a.c
> +++ b/sound/soc/intel/boards/skl_nau88l25_max98357a.c
> @@ -339,8 +339,22 @@ static struct snd_pcm_hw_constraint_list constraints_16000 = {
>  	.list  = rates_16000,
>  };
>  
> +static const unsigned int ch_mono[] = {
> +	1,
> +};
> +
> +static const struct snd_pcm_hw_constraint_list constraints_refcap = {
> +	.count = ARRAY_SIZE(ch_mono),
> +	.list  = ch_mono,
> +};
> +
>  static int skylake_refcap_startup(struct snd_pcm_substream *substream)
>  {
> +	substream->runtime->hw.channels_max = 1;
> +	snd_pcm_hw_constraint_list(substream->runtime, 0,
> +					SNDRV_PCM_HW_PARAM_CHANNELS,
> +					&constraints_refcap);
> +
>  	return snd_pcm_hw_constraint_list(substream->runtime, 0,
>  				SNDRV_PCM_HW_PARAM_RATE,
>  				&constraints_16000);
> -- 
> 1.9.1
> 

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-19  3:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-17 16:43 [PATCH 1/2] ASoC: Intel: Skylake: Add channel constraints for refcap Yong Zhi
2016-05-17 16:43 ` [PATCH 2/2] ASoC: Intel: Skylake: Use refcap device for mono recording Yong Zhi
2016-05-19  3:39 ` [PATCH 1/2] ASoC: Intel: Skylake: Add channel constraints for refcap Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.