All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target
Date: Thu, 19 May 2016 16:02:03 +0300	[thread overview]
Message-ID: <20160519130203.GB2178@tarshish> (raw)
In-Reply-To: <1463659540-28813-1-git-send-email-joerg.krause@embedded.rocks>

Hi J?rg,

On Thu, May 19, 2016 at 02:05:40PM +0200, J?rg Krause wrote:
> From: J?rg Krause <jk@lintech.de>

I think you should keep Julien's authorship of this patch.

> Building an U-Boot image for the i.MX23 or i.MX28 target requires to run the
> bootloaders 'mxsimage' tool on the host. As mxsimage needs unconditionally
> OpenSSL, building U-Boot for those targets fails if it is not available on
> the host:
> 
> tools/mxsimage.c:18:25: fatal error: openssl/evp.h: No such file or directory
>   #include <openssl/evp.h>
> 
> Add the required dependency 'host-openssl' to all the different U-Boot image
> types used to build a bootloader image for an i.MX23/i.MX28 target.
> 
> Fetch from:
> https://sourceforge.net/p/armadeus/mailman/message/33595402/
> 
> Signed-off-by: Julien Boibessot <julien.boibessot@armadeus.com>
> [J?rg: port to recent Buildroot version]
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
>  boot/uboot/uboot.mk | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index e071303..e739638 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -58,16 +58,17 @@ UBOOT_BIN = u-boot.imx
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SB),y)
>  UBOOT_BIN = u-boot.sb
>  UBOOT_MAKE_TARGET = $(UBOOT_BIN)
> -UBOOT_DEPENDENCIES += host-elftosb
> +# mxsimage needs OpenSSL
> +UBOOT_DEPENDENCIES += host-elftosb host-openssl
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_SD),y)
>  # BootStream (.sb) is generated by U-Boot, we convert it to SD format
>  UBOOT_BIN = u-boot.sd
>  UBOOT_MAKE_TARGET = u-boot.sb
> -UBOOT_DEPENDENCIES += host-elftosb
> +UBOOT_DEPENDENCIES += host-elftosb host-openssl
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_NAND),y)
>  UBOOT_BIN = u-boot.nand
>  UBOOT_MAKE_TARGET = u-boot.sb
> -UBOOT_DEPENDENCIES += host-elftosb
> +UBOOT_DEPENDENCIES += host-elftosb host-openssl
>  else ifeq ($(BR2_TARGET_UBOOT_FORMAT_CUSTOM),y)
>  UBOOT_BIN = $(call qstrip,$(BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME))
>  else
> @@ -87,7 +88,9 @@ endif
>  
>  UBOOT_MAKE_OPTS += \
>  	CROSS_COMPILE="$(TARGET_CROSS)" \
> -	ARCH=$(UBOOT_ARCH)
> +	ARCH=$(UBOOT_ARCH) \
> +	HOSTCFLAGS="$(HOST_CFLAGS)" \
> +	HOSTLDFLAGS="$(HOST_LDFLAGS)"

Is this hunk necessary to make mxsimage.c build? If so, please explain how in 
the commit log.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2016-05-19 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 12:05 [Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target Jörg Krause
2016-05-19 13:02 ` Baruch Siach [this message]
2016-05-19 14:03   ` Thomas Petazzoni
2016-05-19 18:27   ` Jörg Krause
2016-05-19 18:39     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160519130203.GB2178@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.