All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target
Date: Thu, 19 May 2016 16:03:18 +0200	[thread overview]
Message-ID: <20160519160318.37fb72f9@free-electrons.com> (raw)
In-Reply-To: <20160519130203.GB2178@tarshish>

Hello,

On Thu, 19 May 2016 16:02:03 +0300, Baruch Siach wrote:

> >  UBOOT_MAKE_OPTS += \
> >  	CROSS_COMPILE="$(TARGET_CROSS)" \
> > -	ARCH=$(UBOOT_ARCH)
> > +	ARCH=$(UBOOT_ARCH) \
> > +	HOSTCFLAGS="$(HOST_CFLAGS)" \
> > +	HOSTLDFLAGS="$(HOST_LDFLAGS)"  
> 
> Is this hunk necessary to make mxsimage.c build? If so, please explain how in 
> the commit log.

I guess it is, to allow the U-Boot build process to find OpenSSL in
$(HOST_DIR): thanks to $(HOST_CFLAGS) and $(HOST_LDFLAGS), the right
-I/-L options will be passed to allow U-Boot to find OpenSSL.

But indeed, it's nice when such things are explicitly said in the
commit log.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-05-19 14:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 12:05 [Buildroot] [PATCH] boot/uboot: fix missing host-openssl for i.MX28 target Jörg Krause
2016-05-19 13:02 ` Baruch Siach
2016-05-19 14:03   ` Thomas Petazzoni [this message]
2016-05-19 18:27   ` Jörg Krause
2016-05-19 18:39     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160519160318.37fb72f9@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.