From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: fix deadlock on failure branch in nvme_get_ns_from_disk()
Date: Fri, 20 May 2016 19:05:28 -0400 [thread overview]
Message-ID: <20160520230527.GA2839@localhost.localdomain> (raw)
In-Reply-To: <1463783760-5851-1-git-send-email-khoroshilov@ispras.ru>
On Sat, May 21, 2016@01:36:00AM +0300, Alexey Khoroshilov wrote:
> kref_put(&ns->kref, nvme_free_ns) is called in nvme_get_ns_from_disk()
> under dev_list_lock spinlock, while nvme_free_ns() locks the spinlock
> by itself. This can lead to a deadlock.
>
> The patch moves try_module_get() and its error handling
> out of spinlock section.
This is also fixed with this earlier posted patch:
http://lists.infradead.org/pipermail/linux-nvme/2016-May/004530.html
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] NVMe: fix deadlock on failure branch in nvme_get_ns_from_disk()
Date: Fri, 20 May 2016 19:05:28 -0400 [thread overview]
Message-ID: <20160520230527.GA2839@localhost.localdomain> (raw)
In-Reply-To: <1463783760-5851-1-git-send-email-khoroshilov@ispras.ru>
On Sat, May 21, 2016 at 01:36:00AM +0300, Alexey Khoroshilov wrote:
> kref_put(&ns->kref, nvme_free_ns) is called in nvme_get_ns_from_disk()
> under dev_list_lock spinlock, while nvme_free_ns() locks the spinlock
> by itself. This can lead to a deadlock.
>
> The patch moves try_module_get() and its error handling
> out of spinlock section.
This is also fixed with this earlier posted patch:
http://lists.infradead.org/pipermail/linux-nvme/2016-May/004530.html
next prev parent reply other threads:[~2016-05-20 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 22:36 [PATCH] NVMe: fix deadlock on failure branch in nvme_get_ns_from_disk() Alexey Khoroshilov
2016-05-20 22:36 ` Alexey Khoroshilov
2016-05-20 23:05 ` Keith Busch [this message]
2016-05-20 23:05 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520230527.GA2839@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.