From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tobin C Harding <me-xzjC0nNlxno@public.gmane.org>
Cc: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
Abdul Hussain <habdul-Vi+0cqmPEYlBDgjK7y7TUQ@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Oleg Drokin <oleg.drokin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
Frank Zago <fzago-WVYJKLFxKCc@public.gmane.org>,
"Kirill A. Shutemov"
<kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
lustre-devel-aLEFhgZF4x6X6Mz3xDxJMA@public.gmane.org
Subject: [lustre-devel] [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user
Date: Sun, 22 May 2016 15:25:38 -0700 [thread overview]
Message-ID: <20160522222538.GA17573@kroah.com> (raw)
In-Reply-To: <1463953771-16942-1-git-send-email-me@tobin.cc>
On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
>
> Signed-off-by: Tobin C Harding <me@tobin.cc>
Why did you send this twice?
> ---
> drivers/gpu/drm/gma500/gma_display.c | 2 +-
> drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
> 2 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index 5bf765d..8a1fb25 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
>
> /* Wait for vblank for the disable to take effect */
> gma_wait_for_vblank(dev);
> -
> +l
What? What does this have to do with lustre?
It's kind of obvious you didn't build this :(
Please be more careful in the future.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Tobin C Harding <me-xzjC0nNlxno@public.gmane.org>
Cc: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
Abdul Hussain <habdul-Vi+0cqmPEYlBDgjK7y7TUQ@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Oleg Drokin <oleg.drokin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Julia Lawall <Julia.Lawall-L2FTfq7BK8M@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
Frank Zago <fzago-WVYJKLFxKCc@public.gmane.org>,
"Kirill A. Shutemov"
<kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
lustre-devel-aLEFhgZF4x6X6Mz3xDxJMA@public.gmane.org
Subject: Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user
Date: Sun, 22 May 2016 15:25:38 -0700 [thread overview]
Message-ID: <20160522222538.GA17573@kroah.com> (raw)
In-Reply-To: <1463953771-16942-1-git-send-email-me-xzjC0nNlxno@public.gmane.org>
On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
>
> Signed-off-by: Tobin C Harding <me-xzjC0nNlxno@public.gmane.org>
Why did you send this twice?
> ---
> drivers/gpu/drm/gma500/gma_display.c | 2 +-
> drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
> 2 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index 5bf765d..8a1fb25 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
>
> /* Wait for vblank for the disable to take effect */
> gma_wait_for_vblank(dev);
> -
> +l
What? What does this have to do with lustre?
It's kind of obvious you didn't build this :(
Please be more careful in the future.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tobin C Harding <me@tobin.cc>
Cc: patrik.r.jakobsson@gmail.com, David Airlie <airlied@linux.ie>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
"John L. Hammond" <john.hammond@intel.com>,
Dmitry Eremin <dmitry.eremin@intel.com>,
Frank Zago <fzago@cray.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Al Viro <viro@zeniv.linux.org.uk>,
James Nunez <james.a.nunez@intel.com>,
Abdul Hussain <habdul@visteon.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user
Date: Sun, 22 May 2016 15:25:38 -0700 [thread overview]
Message-ID: <20160522222538.GA17573@kroah.com> (raw)
In-Reply-To: <1463953771-16942-1-git-send-email-me@tobin.cc>
On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
>
> Signed-off-by: Tobin C Harding <me@tobin.cc>
Why did you send this twice?
> ---
> drivers/gpu/drm/gma500/gma_display.c | 2 +-
> drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
> 2 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index 5bf765d..8a1fb25 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
>
> /* Wait for vblank for the disable to take effect */
> gma_wait_for_vblank(dev);
> -
> +l
What? What does this have to do with lustre?
It's kind of obvious you didn't build this :(
Please be more careful in the future.
greg k-h
next prev parent reply other threads:[~2016-05-22 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 21:49 [lustre-devel] [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user Tobin C Harding
2016-05-22 21:49 ` Tobin C Harding
2016-05-22 22:25 ` Greg Kroah-Hartman [this message]
2016-05-22 22:25 ` Greg Kroah-Hartman
2016-05-22 22:25 ` Greg Kroah-Hartman
2016-05-23 0:20 ` [lustre-devel] " Tobin Harding
2016-05-23 0:20 ` Tobin Harding
2016-05-23 0:20 ` Tobin Harding
-- strict thread matches above, loose matches on Subject: below --
2016-05-22 21:52 [lustre-devel] " Tobin C Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160522222538.GA17573@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Julia.Lawall-L2FTfq7BK8M@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=fzago-WVYJKLFxKCc@public.gmane.org \
--cc=habdul-Vi+0cqmPEYlBDgjK7y7TUQ@public.gmane.org \
--cc=kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lustre-devel-aLEFhgZF4x6X6Mz3xDxJMA@public.gmane.org \
--cc=me-xzjC0nNlxno@public.gmane.org \
--cc=oleg.drokin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.