* [patch] qed: signedness bug in qed_dcbx_process_tlv()
@ 2016-05-23 10:19 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2016-05-23 10:19 UTC (permalink / raw)
To: Yuval Mintz, Sudarsana Reddy Kalluru
Cc: Ariel Elior, everest-linux-l2, netdev, kernel-janitors
"priority" needs to be signed for the error handling to work.
Fixes: 39651abd2814 ('qed: add support for dcbx.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Applies to the main net tree.
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index cbf58e1..a06d19a 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
struct dcbx_app_priority_entry *p_tbl,
u32 pri_tc_tbl, int count, bool dcbx_enabled)
{
- u8 tc, priority, priority_map;
+ u8 tc, priority_map;
enum dcbx_protocol_type type;
u16 protocol_id;
+ int priority;
bool enable;
int i;
^ permalink raw reply related [flat|nested] 5+ messages in thread* [patch] qed: signedness bug in qed_dcbx_process_tlv()
@ 2016-05-23 10:19 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2016-05-23 10:19 UTC (permalink / raw)
To: Yuval Mintz, Sudarsana Reddy Kalluru
Cc: Ariel Elior, everest-linux-l2, netdev, kernel-janitors
"priority" needs to be signed for the error handling to work.
Fixes: 39651abd2814 ('qed: add support for dcbx.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Applies to the main net tree.
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index cbf58e1..a06d19a 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
struct dcbx_app_priority_entry *p_tbl,
u32 pri_tc_tbl, int count, bool dcbx_enabled)
{
- u8 tc, priority, priority_map;
+ u8 tc, priority_map;
enum dcbx_protocol_type type;
u16 protocol_id;
+ int priority;
bool enable;
int i;
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [patch] qed: signedness bug in qed_dcbx_process_tlv()
2016-05-23 10:19 ` Dan Carpenter
(?)
@ 2016-05-23 11:06 ` Sudarsana Kalluru
-1 siblings, 0 replies; 5+ messages in thread
From: Sudarsana Kalluru @ 2016-05-23 11:06 UTC (permalink / raw)
To: Dan Carpenter, Yuval Mintz
Cc: Ariel Elior, Dept-Eng Everest Linux L2, netdev,
kernel-janitors@vger.kernel.org
Thanks, Dan.
Acked-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@qlogic.com>
-----Original Message-----
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
Sent: 23 May 2016 15:50
To: Yuval Mintz <Yuval.Mintz@qlogic.com>; Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>
Cc: Ariel Elior <Ariel.Elior@qlogic.com>; Dept-Eng Everest Linux L2 <everest-linux-l2@qlogic.com>; netdev <netdev@vger.kernel.org>; kernel-janitors@vger.kernel.org
Subject: [patch] qed: signedness bug in qed_dcbx_process_tlv()
"priority" needs to be signed for the error handling to work.
Fixes: 39651abd2814 ('qed: add support for dcbx.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Applies to the main net tree.
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index cbf58e1..a06d19a 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
struct dcbx_app_priority_entry *p_tbl,
u32 pri_tc_tbl, int count, bool dcbx_enabled) {
- u8 tc, priority, priority_map;
+ u8 tc, priority_map;
enum dcbx_protocol_type type;
u16 protocol_id;
+ int priority;
bool enable;
int i;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch] qed: signedness bug in qed_dcbx_process_tlv()
2016-05-23 10:19 ` Dan Carpenter
@ 2016-05-23 22:11 ` David Miller
-1 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2016-05-23 22:11 UTC (permalink / raw)
To: dan.carpenter
Cc: Yuval.Mintz, sudarsana.kalluru, Ariel.Elior, everest-linux-l2,
netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 23 May 2016 13:19:35 +0300
> "priority" needs to be signed for the error handling to work.
>
> Fixes: 39651abd2814 ('qed: add support for dcbx.')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] qed: signedness bug in qed_dcbx_process_tlv()
@ 2016-05-23 22:11 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2016-05-23 22:11 UTC (permalink / raw)
To: dan.carpenter
Cc: Yuval.Mintz, sudarsana.kalluru, Ariel.Elior, everest-linux-l2,
netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 23 May 2016 13:19:35 +0300
> "priority" needs to be signed for the error handling to work.
>
> Fixes: 39651abd2814 ('qed: add support for dcbx.')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-23 22:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-23 10:19 [patch] qed: signedness bug in qed_dcbx_process_tlv() Dan Carpenter
2016-05-23 10:19 ` Dan Carpenter
2016-05-23 11:06 ` Sudarsana Kalluru
2016-05-23 22:11 ` David Miller
2016-05-23 22:11 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.