All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/mm: avoid possible null pointer dereference
Date: Mon, 23 May 2016 11:27:14 +0100	[thread overview]
Message-ID: <20160523102714.GA13596@imgtec.com> (raw)
In-Reply-To: <1463602639-4861-1-git-send-email-xypron.glpk@gmx.de>

On Wed, May 18, 2016 at 10:17:19PM +0200, Heinrich Schuchardt wrote:
> Do not dereference node before the check if node is NULL.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/gpu/drm/drm_mm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
> index 04de6fd..cb39f45 100644
> --- a/drivers/gpu/drm/drm_mm.c
> +++ b/drivers/gpu/drm/drm_mm.c
> @@ -179,12 +179,14 @@ static void drm_mm_insert_helper(struct drm_mm_node *hole_node,
>  int drm_mm_reserve_node(struct drm_mm *mm, struct drm_mm_node *node)
>  {
>  	struct drm_mm_node *hole;
> -	u64 end = node->start + node->size;
> +	u64 end;
>  	u64 hole_start;
>  	u64 hole_end;
>  
>  	BUG_ON(node == NULL);
>  
> +	end = node->start + node->size;
> +
>  	/* Find the relevant hole to add our node to */
>  	drm_mm_for_each_hole(hole, mm, hole_start, hole_end) {
>  		if (hole_start > node->start || hole_end < end)
> -- 
> 2.1.4

Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: David Airlie <airlied@linux.ie>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/mm: avoid possible null pointer dereference
Date: Mon, 23 May 2016 11:27:14 +0100	[thread overview]
Message-ID: <20160523102714.GA13596@imgtec.com> (raw)
In-Reply-To: <1463602639-4861-1-git-send-email-xypron.glpk@gmx.de>

On Wed, May 18, 2016 at 10:17:19PM +0200, Heinrich Schuchardt wrote:
> Do not dereference node before the check if node is NULL.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/gpu/drm/drm_mm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
> index 04de6fd..cb39f45 100644
> --- a/drivers/gpu/drm/drm_mm.c
> +++ b/drivers/gpu/drm/drm_mm.c
> @@ -179,12 +179,14 @@ static void drm_mm_insert_helper(struct drm_mm_node *hole_node,
>  int drm_mm_reserve_node(struct drm_mm *mm, struct drm_mm_node *node)
>  {
>  	struct drm_mm_node *hole;
> -	u64 end = node->start + node->size;
> +	u64 end;
>  	u64 hole_start;
>  	u64 hole_end;
>  
>  	BUG_ON(node == NULL);
>  
> +	end = node->start + node->size;
> +
>  	/* Find the relevant hole to add our node to */
>  	drm_mm_for_each_hole(hole, mm, hole_start, hole_end) {
>  		if (hole_start > node->start || hole_end < end)
> -- 
> 2.1.4

Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

  reply	other threads:[~2016-05-23 10:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 20:17 [PATCH] drm/mm: avoid possible null pointer dereference Heinrich Schuchardt
2016-05-23 10:27 ` Eric Engestrom [this message]
2016-05-23 10:27   ` Eric Engestrom
2016-05-23 12:56   ` Daniel Vetter
2016-05-23 12:56     ` Daniel Vetter
2016-05-23 13:02     ` Chris Wilson
2016-05-23 13:38       ` Eric Engestrom
2016-05-23 13:38         ` Eric Engestrom
2016-05-23 13:46         ` Chris Wilson
2016-05-23 13:46           ` Chris Wilson
2016-05-23 15:35           ` Eric Engestrom
2016-05-23 15:35             ` Eric Engestrom
2016-05-23 15:50             ` Chris Wilson
2016-05-23 15:50               ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160523102714.GA13596@imgtec.com \
    --to=eric.engestrom@imgtec.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.