From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/2] nvme/pci: Enable SR-IOV capabilities
Date: Mon, 23 May 2016 13:21:44 -0400 [thread overview]
Message-ID: <20160523172144.GD17208@localhost.localdomain> (raw)
In-Reply-To: <20160523170652.GA12826@localhost>
On Mon, May 23, 2016@12:06:52PM -0500, Bjorn Helgaas wrote:
> I do not subscribe to the belief that every function should have a
> single exit. In this case, I think it makes the function much harder
> to understand than this:
No problem with multiple exists.
> if (numvfs == 0)
> pci_disable_sriov(pdev);
> return 0;
> }
>
> return pci_enable_sriov(pdev, numvfs);
Slight change to the above: pci_enable_sriov returns 0 on success,
but a driver's .sriov_configure is supposed to return the number of
VF's successfully configured, so need to return 'numvfs' on success.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/2] nvme/pci: Enable SR-IOV capabilities
Date: Mon, 23 May 2016 13:21:44 -0400 [thread overview]
Message-ID: <20160523172144.GD17208@localhost.localdomain> (raw)
In-Reply-To: <20160523170652.GA12826@localhost>
On Mon, May 23, 2016 at 12:06:52PM -0500, Bjorn Helgaas wrote:
> I do not subscribe to the belief that every function should have a
> single exit. In this case, I think it makes the function much harder
> to understand than this:
No problem with multiple exists.
> if (numvfs == 0)
> pci_disable_sriov(pdev);
> return 0;
> }
>
> return pci_enable_sriov(pdev, numvfs);
Slight change to the above: pci_enable_sriov returns 0 on success,
but a driver's .sriov_configure is supposed to return the number of
VF's successfully configured, so need to return 'numvfs' on success.
next prev parent reply other threads:[~2016-05-23 17:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 21:39 [PATCH 1/2] pci: Error disabling SR-IOV if in VFs assigned Keith Busch
2016-05-17 21:39 ` Keith Busch
2016-05-17 21:39 ` [PATCH 2/2] nvme/pci: Enable SR-IOV capabilities Keith Busch
2016-05-17 21:39 ` Keith Busch
2016-05-23 10:52 ` Christoph Hellwig
2016-05-23 10:52 ` Christoph Hellwig
2016-05-23 17:06 ` Bjorn Helgaas
2016-05-23 17:06 ` Bjorn Helgaas
2016-05-23 17:09 ` Christoph Hellwig
2016-05-23 17:09 ` Christoph Hellwig
2016-05-23 17:21 ` Keith Busch [this message]
2016-05-23 17:21 ` Keith Busch
2016-05-23 21:51 ` Bjorn Helgaas
2016-05-23 21:51 ` Bjorn Helgaas
2016-05-17 22:08 ` [PATCH 1/2] pci: Error disabling SR-IOV if in VFs assigned Alex Williamson
2016-05-17 22:08 ` Alex Williamson
2016-05-23 10:55 ` Christoph Hellwig
2016-05-23 10:55 ` Christoph Hellwig
2016-05-23 15:07 ` Alex Williamson
2016-05-23 15:07 ` Alex Williamson
2016-05-23 15:10 ` Christoph Hellwig
2016-05-23 15:10 ` Christoph Hellwig
2016-06-13 21:14 ` Bjorn Helgaas
2016-06-13 21:14 ` Bjorn Helgaas
2016-06-13 21:28 ` Keith Busch
2016-06-13 21:28 ` Keith Busch
2016-06-13 21:57 ` Keith Busch
2016-06-13 21:57 ` Keith Busch
2016-06-13 22:26 ` Bjorn Helgaas
2016-06-13 22:26 ` Bjorn Helgaas
2016-06-13 22:35 ` Keith Busch
2016-06-13 22:35 ` Keith Busch
2016-06-15 10:26 ` Christoph Hellwig
2016-06-15 10:26 ` Christoph Hellwig
2016-06-15 15:38 ` Bjorn Helgaas
2016-06-15 15:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523172144.GD17208@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.