All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bob Peterson <rpeterso@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
	vishal l verma <vishal.l.verma@intel.com>,
	Christoph Hellwig <hch@lst.de>,
	xfs@oss.sgi.com
Subject: Re: [PATCH 09/15] fs: iomap based fiemap implementation
Date: Tue, 24 May 2016 15:10:58 +0200	[thread overview]
Message-ID: <20160524131058.GA21094@lst.de> (raw)
In-Reply-To: <1651455378.10041082.1464034166002.JavaMail.zimbra@redhat.com>

On Mon, May 23, 2016 at 04:09:26PM -0400, Bob Peterson wrote:
> I've been looking at this again. Where are the calls to the fs-specific bits
> for fiemap?

In the iomap_ops structure passed to iomap_fiemap.

> It looks like iomap_fiemap calls iomap_apply, which calls
> iomap_fiemap_actor, but that doesn't call any ops->iomap_get_iomap or similar.
> It calls the iomap_begin (which BTW has a comment that says "Execute a iomap
> write" which is probably wrong and should be more generic, as for cases like
> fiemap) and it calls iomap_end. But it never calls an fs-specific actor
> anywhere. Am I missing something? My earlier version passed in the actor
> function, as per Dave Chinner's request, but yours doesn't.

The iomap_begin callback is where you do the mapping.  the iomap_end
callback does any required cleanup, which in case of GFS2 probably
would be dropping the cluster lock protecting the mapping.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Bob Peterson <rpeterso@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	xfs@oss.sgi.com, vishal l verma <vishal.l.verma@intel.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 09/15] fs: iomap based fiemap implementation
Date: Tue, 24 May 2016 15:10:58 +0200	[thread overview]
Message-ID: <20160524131058.GA21094@lst.de> (raw)
In-Reply-To: <1651455378.10041082.1464034166002.JavaMail.zimbra@redhat.com>

On Mon, May 23, 2016 at 04:09:26PM -0400, Bob Peterson wrote:
> I've been looking at this again. Where are the calls to the fs-specific bits
> for fiemap?

In the iomap_ops structure passed to iomap_fiemap.

> It looks like iomap_fiemap calls iomap_apply, which calls
> iomap_fiemap_actor, but that doesn't call any ops->iomap_get_iomap or similar.
> It calls the iomap_begin (which BTW has a comment that says "Execute a iomap
> write" which is probably wrong and should be more generic, as for cases like
> fiemap) and it calls iomap_end. But it never calls an fs-specific actor
> anywhere. Am I missing something? My earlier version passed in the actor
> function, as per Dave Chinner's request, but yours doesn't.

The iomap_begin callback is where you do the mapping.  the iomap_end
callback does any required cleanup, which in case of GFS2 probably
would be dropping the cluster lock protecting the mapping.

  reply	other threads:[~2016-05-24 13:11 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09  8:47 iomap infrastructure and multipage writes V4 Christoph Hellwig
2016-05-09  8:47 ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 01/15] dax: export a low-level __dax_zero_page_range helper Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-11 22:43   ` Verma, Vishal L
2016-05-11 22:43     ` Verma, Vishal L
2016-05-09  8:47 ` [PATCH 02/15] fs: move struct iomap from exportfs.h to a separate header Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 03/15] fs: introduce iomap infrastructure Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 04/15] fs: support DAX based iomap zeroing Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 05/15] xfs: make xfs_bmbt_to_iomap available outside of xfs_pnfs.c Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 06/15] xfs: reorder zeroing and flushing sequence in truncate Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 07/15] xfs: implement iomap based buffered write path Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 08/15] xfs: remove buffered write support from __xfs_get_blocks Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 09/15] fs: iomap based fiemap implementation Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-23 20:09   ` Bob Peterson
2016-05-23 20:09     ` Bob Peterson
2016-05-24 13:10     ` Christoph Hellwig [this message]
2016-05-24 13:10       ` Christoph Hellwig
2016-05-26 18:19       ` Bob Peterson
2016-05-26 18:19         ` Bob Peterson
2016-05-26 22:57         ` Dave Chinner
2016-05-26 22:57           ` Dave Chinner
2016-05-09  8:47 ` [PATCH 10/15] xfs: use iomap " Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 11/15] xfs: use iomap infrastructure for DAX zeroing Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 12/15] xfs: handle 64-bit length in xfs_iozero Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 13/15] xfs: use xfs_zero_range in xfs_zero_eof Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 14/15] xfs: split xfs_free_file_space in manageable pieces Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-09  8:47 ` [PATCH 15/15] xfs: kill xfs_zero_remaining_bytes Christoph Hellwig
2016-05-09  8:47   ` Christoph Hellwig
2016-05-11 22:42 ` iomap infrastructure and multipage writes V4 Verma, Vishal L
2016-05-11 22:42   ` Verma, Vishal L
2016-06-01  6:35 ` Dave Chinner
2016-06-01  6:35   ` Dave Chinner
2016-06-01 12:31   ` Christoph Hellwig
2016-06-01 12:31     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160524131058.GA21094@lst.de \
    --to=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=rpeterso@redhat.com \
    --cc=vishal.l.verma@intel.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.