All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov@virtuozzo.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	David Rientjes <rientjes@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: oom_kill_process: do not abort if the victim is exiting
Date: Wed, 25 May 2016 18:20:40 +0300	[thread overview]
Message-ID: <20160525152040.GA23127@esperanza> (raw)
In-Reply-To: <20160525080946.GC20132@dhcp22.suse.cz>

On Wed, May 25, 2016 at 10:09:46AM +0200, Michal Hocko wrote:
...
> Well, my understanding of the OOM report is that it should tell you two
> things. The first one is to give you an overview of the overal memory
> situation when the system went OOM and the second one is o give you
> information that something has been _killed_ and what was the criteria
> why it has been selected (points). While the first one might be
> interesting for what you write above the second is not and it might be
> even misleading because we are not killing anything and the selected
> task is dying without the kernel intervention.

Fair enough. Printing that a task was killed while it actually died
voluntarily is not good. And select_bad_process may select dying tasks.
So let's leave it as is for now.

Thanks,
Vladimir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Davydov <vdavydov@virtuozzo.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	David Rientjes <rientjes@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: oom_kill_process: do not abort if the victim is exiting
Date: Wed, 25 May 2016 18:20:40 +0300	[thread overview]
Message-ID: <20160525152040.GA23127@esperanza> (raw)
In-Reply-To: <20160525080946.GC20132@dhcp22.suse.cz>

On Wed, May 25, 2016 at 10:09:46AM +0200, Michal Hocko wrote:
...
> Well, my understanding of the OOM report is that it should tell you two
> things. The first one is to give you an overview of the overal memory
> situation when the system went OOM and the second one is o give you
> information that something has been _killed_ and what was the criteria
> why it has been selected (points). While the first one might be
> interesting for what you write above the second is not and it might be
> even misleading because we are not killing anything and the selected
> task is dying without the kernel intervention.

Fair enough. Printing that a task was killed while it actually died
voluntarily is not good. And select_bad_process may select dying tasks.
So let's leave it as is for now.

Thanks,
Vladimir

  reply	other threads:[~2016-05-25 15:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 12:24 [PATCH] mm: oom_kill_process: do not abort if the victim is exiting Vladimir Davydov
2016-05-24 12:24 ` Vladimir Davydov
2016-05-24 13:50 ` Michal Hocko
2016-05-24 13:50   ` Michal Hocko
2016-05-24 15:05   ` Tetsuo Handa
2016-05-24 15:05     ` Tetsuo Handa
2016-05-24 17:07   ` Vladimir Davydov
2016-05-24 17:07     ` Vladimir Davydov
2016-05-25  8:09     ` Michal Hocko
2016-05-25  8:09       ` Michal Hocko
2016-05-25 15:20       ` Vladimir Davydov [this message]
2016-05-25 15:20         ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160525152040.GA23127@esperanza \
    --to=vdavydov@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.