From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Andy Lutomirski <luto@amacapital.net>, Jan Kara <jack@suse.cz>,
yalin wang <yalin.wang2010@gmail.com>, Willy Tarreau <w@1wt.eu>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9] fs: clear file privilege bits when mmap writing
Date: Wed, 25 May 2016 22:49:35 +0100 [thread overview]
Message-ID: <20160525214935.GI14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAGXu5j+cwZQfnSPQNjb=VVzZfJH8n=iZUCM+vz_a6nPku5tQ2g@mail.gmail.com>
On Wed, May 25, 2016 at 02:36:57PM -0700, Kees Cook wrote:
> Hm, this didn't end up getting picked up. (This jumped out at me again
> because i_mutex just vanished...)
>
> Al, what's the right way to update the locking in this patch?
->i_mutex is dealt with just by using lock_inode(inode)/unlock_inode(inode);
I hadn't looked at the rest of the locking in there.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Andy Lutomirski <luto@amacapital.net>, Jan Kara <jack@suse.cz>,
yalin wang <yalin.wang2010@gmail.com>, Willy Tarreau <w@1wt.eu>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9] fs: clear file privilege bits when mmap writing
Date: Wed, 25 May 2016 22:49:35 +0100 [thread overview]
Message-ID: <20160525214935.GI14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAGXu5j+cwZQfnSPQNjb=VVzZfJH8n=iZUCM+vz_a6nPku5tQ2g@mail.gmail.com>
On Wed, May 25, 2016 at 02:36:57PM -0700, Kees Cook wrote:
> Hm, this didn't end up getting picked up. (This jumped out at me again
> because i_mutex just vanished...)
>
> Al, what's the right way to update the locking in this patch?
->i_mutex is dealt with just by using lock_inode(inode)/unlock_inode(inode);
I hadn't looked at the rest of the locking in there.
next prev parent reply other threads:[~2016-05-25 21:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 21:22 [PATCH v9] fs: clear file privilege bits when mmap writing Kees Cook
2016-01-14 21:22 ` Kees Cook
2016-01-15 5:55 ` Konstantin Khlebnikov
2016-01-15 5:55 ` Konstantin Khlebnikov
2016-01-15 6:18 ` Andy Lutomirski
2016-01-15 6:18 ` Andy Lutomirski
2016-01-15 6:36 ` Konstantin Khlebnikov
2016-01-15 6:36 ` Konstantin Khlebnikov
2016-05-25 21:36 ` Kees Cook
2016-05-25 21:36 ` Kees Cook
2016-05-25 21:49 ` Al Viro [this message]
2016-05-25 21:49 ` Al Viro
2017-01-28 3:47 ` Andy Lutomirski
2017-01-28 3:47 ` Andy Lutomirski
2017-02-07 20:18 ` Kees Cook
2017-02-07 20:18 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525214935.GI14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=w@1wt.eu \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.