From: "Pali Rohár" <pali.rohar@gmail.com>
To: Ben Gamari <ben@smart-cactus.org>
Cc: linux-input@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Allen Hung <Allen_Hung@dell.com>,
Masaki Ota <masaki.ota@jp.alps.com>
Subject: Re: [PATCH 3/3] input/alps: Add device description for Dell Latitude E7470
Date: Thu, 26 May 2016 11:05:09 +0200 [thread overview]
Message-ID: <20160526090509.GE29844@pali> (raw)
In-Reply-To: <1464252914-11450-4-git-send-email-ben@smart-cactus.org>
On Thursday 26 May 2016 10:55:14 Ben Gamari wrote:
> ---
> drivers/input/mouse/alps.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 10e6836..eb4bf31 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -143,6 +143,7 @@ static const struct alps_model_info alps_model_data[] = {
> { { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
> ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } }, /* Toshiba Tecra A11-11L */
> { { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
> + { { 0x73, 0x03, 0x28 }, 0x00, { ALPS_PROTO_V8, 0x18, 0x18, ALPS_SS4_V2_ALT_DECODING | ALPS_DUALPOINT } }, /* Dell Latitude E7470 */
> };
>
> static const struct alps_protocol_info alps_v3_protocol_data = {
Hi! I would rather move this code into alps_identify and probably create
alps_v8_ss<name>_data structure for it.
Above alps_model_data list looks like hooks for special touchpads which
needs more flags to work correctly...
--
Pali Rohár
pali.rohar@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-26 9:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 13:31 Dell Latitude E7470 touchpad status Ben Gamari
[not found] ` <23E0F704395E694FA4710C833FA087E50D40B8BF13@TPEX7ADC101.APAC.DELL.COM>
2016-05-17 6:03 ` Ben Gamari
2016-05-17 8:23 ` Pali Rohár
2016-05-17 9:50 ` Ben Gamari
2016-05-17 13:16 ` Pali Rohár
2016-05-17 14:46 ` Allen_Hung
2016-05-17 15:22 ` Pali Rohár
2016-05-25 4:38 ` Allen_Hung
2016-05-25 7:39 ` Pali Rohár
2016-05-25 12:09 ` Ben Gamari
2016-05-25 14:45 ` Pali Rohár
2016-05-25 15:19 ` Hans de Goede
2016-05-25 15:32 ` Pali Rohár
2016-05-25 12:32 ` Ben Gamari
2016-05-25 15:43 ` Pali Rohár
2016-05-25 15:47 ` Hans de Goede
2016-05-25 15:53 ` Ben Gamari
2016-05-25 16:01 ` Packet format for ALPS V8 trackstick (Was: Re: Dell Latitude E7470 touchpad status) Pali Rohár
2016-05-26 8:55 ` [PATCH] Alps SS4 V2 support for Dell Latitude 7470 Ben Gamari
2016-05-26 8:55 ` [PATCH 1/3] input/alps: Split up ALPS_BUTTONPAD behavior change Ben Gamari
2016-05-26 8:55 ` [PATCH 2/3] input/alps: Add touchstick support for V8 protocol devices Ben Gamari
2016-05-26 8:55 ` [PATCH 3/3] input/alps: Add device description for Dell Latitude E7470 Ben Gamari
2016-05-26 9:05 ` Pali Rohár [this message]
2016-05-26 12:19 ` Hans de Goede
2016-05-26 12:35 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526090509.GE29844@pali \
--to=pali.rohar@gmail.com \
--cc=Allen_Hung@dell.com \
--cc=ben@smart-cactus.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.