All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Gamari <ben@smart-cactus.org>
To: "Pali Rohár" <pali.rohar@gmail.com>,
	"Hans de Goede" <hdegoede@redhat.com>
Cc: Allen_Hung@Dell.com, Mario_Limonciello@Dell.com,
	linux-input@vger.kernel.org, Masaki Ota <masaki.ota@jp.alps.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: Dell Latitude E7470 touchpad status
Date: Wed, 25 May 2016 17:53:22 +0200	[thread overview]
Message-ID: <8737p6jfrh.fsf@smart-cactus.org> (raw)
In-Reply-To: <20160525154310.GZ29844@pali>

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

Pali Rohár <pali.rohar@gmail.com> writes:

> On Wednesday 25 May 2016 14:32:28 Ben Gamari wrote:
>> 
>> The first attached patch gets me partly there; I see multitouch events,
>> the pressure appears to reflect reality, and things generally work as
>> expected. That is, until I try to touch the touchstick, which causes the
>> pointer to jump around wildly.
>
> So with first patch touchpad starts working fine and just trackstick
> cause problems?
>
> Reason for non working trackstick is simple. Driver alps.c does not
> support trackstick in V8 protocol. So you even does not see second
> (trackstick) input device, right?
>
Correct.

>> The second attached patch makes things behave slightly better,
>
> Looking at the alps.c code it should act exactly same. V8 does not
> support trackpoint, so ALPS_DUALPOINT has no effect. There should not be
> any difference between your first and second patch. Can you play more
> and confirm it?
>
Ahh, so you are right. I apparently misread the code.

>> but the touchstick still does not work as expected. Settting
>> ALPS_PS2_INTERLEAVED as well doesn't appear to change anything.
>
> ALPS_PS2_INTERLEAVED is just for V2 protocol. It does not have any
> effect for other protocols.
>
Good to know. It would be nice if there were a comment indicating this
in alps.c.

>> Ideas?
>
> I think now we just need description of trackstick format for V8
> protocol. And then implement it in alps V8 parser.
>
Lovely. I'd be happy to carry out the implementation if protocol
documentation is available.

Cheers,

- Ben

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

  parent reply	other threads:[~2016-05-25 15:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 13:31 Dell Latitude E7470 touchpad status Ben Gamari
     [not found] ` <23E0F704395E694FA4710C833FA087E50D40B8BF13@TPEX7ADC101.APAC.DELL.COM>
2016-05-17  6:03   ` Ben Gamari
2016-05-17  8:23     ` Pali Rohár
2016-05-17  9:50       ` Ben Gamari
2016-05-17 13:16         ` Pali Rohár
2016-05-17 14:46           ` Allen_Hung
2016-05-17 15:22             ` Pali Rohár
2016-05-25  4:38               ` Allen_Hung
2016-05-25  7:39                 ` Pali Rohár
2016-05-25 12:09                   ` Ben Gamari
2016-05-25 14:45                     ` Pali Rohár
2016-05-25 15:19                       ` Hans de Goede
2016-05-25 15:32                         ` Pali Rohár
2016-05-25 12:32                   ` Ben Gamari
2016-05-25 15:43                     ` Pali Rohár
2016-05-25 15:47                       ` Hans de Goede
2016-05-25 15:53                       ` Ben Gamari [this message]
2016-05-25 16:01                         ` Packet format for ALPS V8 trackstick (Was: Re: Dell Latitude E7470 touchpad status) Pali Rohár
2016-05-26  8:55                           ` [PATCH] Alps SS4 V2 support for Dell Latitude 7470 Ben Gamari
2016-05-26  8:55                             ` [PATCH 1/3] input/alps: Split up ALPS_BUTTONPAD behavior change Ben Gamari
2016-05-26  8:55                             ` [PATCH 2/3] input/alps: Add touchstick support for V8 protocol devices Ben Gamari
2016-05-26  8:55                             ` [PATCH 3/3] input/alps: Add device description for Dell Latitude E7470 Ben Gamari
2016-05-26  9:05                               ` Pali Rohár
2016-05-26 12:19                                 ` Hans de Goede
2016-05-26 12:35                                   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737p6jfrh.fsf@smart-cactus.org \
    --to=ben@smart-cactus.org \
    --cc=Allen_Hung@Dell.com \
    --cc=Mario_Limonciello@Dell.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=masaki.ota@jp.alps.com \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.