From: "Michael Büsch" <m@bues.ch>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-wlan-client-support-list@broadcom.com, 1332647@gmail.com,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: BCM4331 reset leads to wl lockup
Date: Thu, 26 May 2016 14:42:46 +0200 [thread overview]
Message-ID: <20160526144246.217bfff1@wiggum> (raw)
In-Reply-To: <20160526121210.GA7006@wunner.de>
On Thu, 26 May 2016 14:12:10 +0200
Lukas Wunner <lukas@wunner.de> wrote:
> + mmio = early_ioremap(addr, BCM4331_MMIO_SIZE);
> + if (!mmio) {
> + pr_err("Cannot iomap Apple AirPort card\n");
> + return;
> + }
> + pr_info("Resetting Apple AirPort card\n");
> + iowrite32(BCMA_RESET_CTL_RESET,
> + mmio + (1 * BCMA_CORE_SIZE) + BCMA_RESET_CTL);
> + early_iounmap(mmio, BCM4331_MMIO_SIZE);
Just writing that bit is not the correct reset procedure.
So it might cause problems depending on how wl does the core reset
later.
Please try this:
- wait for BCMA_RESET_ST to be 0
- set reset bit
- flush
- wait 1us
- reset reset bit
- flush
- wait 10us
See bcma_core_disable()
--
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20160526/cabe4088/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <m@bues.ch>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-wlan-client-support-list@broadcom.com, 1332647@gmail.com,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: BCM4331 reset leads to wl lockup
Date: Thu, 26 May 2016 14:42:46 +0200 [thread overview]
Message-ID: <20160526144246.217bfff1@wiggum> (raw)
In-Reply-To: <20160526121210.GA7006@wunner.de>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On Thu, 26 May 2016 14:12:10 +0200
Lukas Wunner <lukas@wunner.de> wrote:
> + mmio = early_ioremap(addr, BCM4331_MMIO_SIZE);
> + if (!mmio) {
> + pr_err("Cannot iomap Apple AirPort card\n");
> + return;
> + }
> + pr_info("Resetting Apple AirPort card\n");
> + iowrite32(BCMA_RESET_CTL_RESET,
> + mmio + (1 * BCMA_CORE_SIZE) + BCMA_RESET_CTL);
> + early_iounmap(mmio, BCM4331_MMIO_SIZE);
Just writing that bit is not the correct reset procedure.
So it might cause problems depending on how wl does the core reset
later.
Please try this:
- wait for BCMA_RESET_ST to be 0
- set reset bit
- flush
- wait 1us
- reset reset bit
- flush
- wait 10us
See bcma_core_disable()
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-26 12:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 12:12 BCM4331 reset leads to wl lockup Lukas Wunner
2016-05-26 12:12 ` Lukas Wunner
2016-05-26 12:42 ` Michael Büsch [this message]
2016-05-26 12:42 ` Michael Büsch
2016-05-29 11:02 ` Lukas Wunner
2016-05-29 11:02 ` Lukas Wunner
2016-05-29 18:48 ` Arend van Spriel
2016-05-29 18:48 ` Arend van Spriel
2016-05-29 18:55 ` Arend van Spriel
2016-05-29 18:55 ` Arend van Spriel
2016-05-29 23:52 ` Lukas Wunner
2016-05-29 23:52 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526144246.217bfff1@wiggum \
--to=m@bues.ch \
--cc=1332647@gmail.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wlan-client-support-list@broadcom.com \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.