From: Wolfram Sang <wsa@the-dreams.de>
To: Sricharan R <sricharan@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, ntelkar@codeaurora.org,
galak@codeaurora.org, linux-kernel@vger.kernel.org,
andy.gross@linaro.org, linux-i2c@vger.kernel.org,
agross@codeaurora.org, linux-arm-kernel@lists.infradead.org,
nkaje@codeaurora.org, absahu@codeaurora.org
Subject: Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled
Date: Thu, 26 May 2016 20:48:05 +0200 [thread overview]
Message-ID: <20160526184805.GC1614@katana> (raw)
In-Reply-To: <1464164212-11377-2-git-send-email-sricharan@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
> sg_set_buf expects that the buf parameter passed in should be from
> lowmem and a valid pageframe. This is not true for pages from
> dma_alloc_coherent which can be carveouts, hence the check fails.
OK, given you mean dma_pool_alloc here, the check fails for the
pageframe because of the pool? Is my understanding correct?
> Change allocation of sg buffers from dma_coherent memory to kzalloc
> to fix the issue.
But why can you drop the coherency?
> @@ -1268,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> }
> }
>
> + idx = 0;
> +
This looks like an unrelated change.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled
Date: Thu, 26 May 2016 20:48:05 +0200 [thread overview]
Message-ID: <20160526184805.GC1614@katana> (raw)
In-Reply-To: <1464164212-11377-2-git-send-email-sricharan@codeaurora.org>
> sg_set_buf expects that the buf parameter passed in should be from
> lowmem and a valid pageframe. This is not true for pages from
> dma_alloc_coherent which can be carveouts, hence the check fails.
OK, given you mean dma_pool_alloc here, the check fails for the
pageframe because of the pool? Is my understanding correct?
> Change allocation of sg buffers from dma_coherent memory to kzalloc
> to fix the issue.
But why can you drop the coherency?
> @@ -1268,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> }
> }
>
> + idx = 0;
> +
This looks like an unrelated change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160526/fc8f1e78/attachment.sig>
next prev parent reply other threads:[~2016-05-26 18:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 8:16 [PATCH V3 0/2] i2c: qup: Some misc fixes Sricharan R
2016-05-25 8:16 ` Sricharan R
2016-05-25 8:16 ` [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled Sricharan R
2016-05-25 8:16 ` Sricharan R
2016-05-26 18:48 ` Wolfram Sang [this message]
2016-05-26 18:48 ` Wolfram Sang
2016-05-26 22:01 ` Sricharan
2016-05-26 22:01 ` Sricharan
2016-05-26 22:01 ` Sricharan
2016-06-09 20:46 ` Wolfram Sang
2016-06-09 20:46 ` Wolfram Sang
2016-05-25 8:16 ` [PATCH V3 2/2] i2c: qup: Fix error handling Sricharan R
2016-05-25 8:16 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160526184805.GC1614@katana \
--to=wsa@the-dreams.de \
--cc=absahu@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=galak@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nkaje@codeaurora.org \
--cc=ntelkar@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.