Re: [PATCH 1/3] orangefs: Remove useless defines

[Al Viro <viro@ZenIV.linux.org.uk>]

On Thu, May 26, 2016 at 03:44:23PM -0400, Mike Marshall wrote:
> Hi Andreas...
> 
> I've looked over your patch series, and was about
> to apply it and run some tests... but the first patch
> "orangefs: Remove useless defines" won't apply.
> 
> I received your patch series a day or so after I merged
> our kernel.org tree up to 4.6, and at first I thought maybe
> you'd composed your patch during the long spell when
> the last commit in our tree was e56f49814250f4ca4b66ec7d3a71152846761d1b,
> resulting in some kind of conflict, but that's not it. Now
> that we're upstream, you're probably patching against
> the "real" Linux tree anyhow...
> 
> Here's where the fail happens:
> 
> @@ -470,7 +470,7 @@ static int orangefs_xattr_get_default(const struct
> xattr_handler *handler,
>                                       size_t size)
>  {
>         return orangefs_inode_getxattr(inode,
> -                                   ORANGEFS_XATTR_NAME_DEFAULT_PREFIX,
> +                                   "",
>                                     name,
>                                     buffer,
>                                     size);
> 
> "return orangefs_inode_getxattr(inode," should be
> "return orangefs_inode_getxattr(dentry->d_inode,"
> 
> I looked way back in time, and don't think it ever
> was "inode" instead of "dentry->d_inode", or how
> it could ever be.

Mainline has ->getxattr() called with dentry and inode passed separately;
moreover, dentry is *NOT* guaranteed to be already associated with the
inode.  See commit ce23e64 and, subsequently, b96809.