All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mike Marshall <hubcap@omnibond.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/3] orangefs: Remove useless defines
Date: Fri, 27 May 2016 00:53:03 +0100	[thread overview]
Message-ID: <20160526235303.GN14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAOg9mSS8qnqxmVzPRvSnxREZNkWHJxz7YOHzCVZ=ewqR8XPydg@mail.gmail.com>

On Thu, May 26, 2016 at 06:24:22PM -0400, Mike Marshall wrote:
> OK... I see now... ce23e64 (Al's patch) got merged to mainline after
> 2dcd0af (Linux 4.6) and Andreas' Orangefs patches won't load
> without ce23e64. I was working from vanilla Linux 4.6. My little
> O_DIRECT patch is also affected, since .direct_IO lost the offset
> argument.
> 
> So... now  the top of my local tree is ea8ea73, Andreas' patch
> series loads fine, I've fixed my O_DIRECT patch, it loads, and
> the whole thing compiles and installs great. But won't boot. On my VM.
> Even when built without Andreas' patch series and my O_DIRECT patch
> it won't boot. So now I've got it booted with the vanilla 4.6 kernel.
> 
> I guess this is a "tree of the moment" problem. I guess Linus' tree
> will continue to evolve and I'll come in tomorrow
> and fetch from it again and it will boot. And then I can load
> and test the patches, update the Orangefs linux-next and
> build the pull request before the merge window ends.
> 
> Maybe after six or eight more merge windows I'll get the
> hang of being upstream and quit causing trouble <g>...

Useful tip: run the tests you care about on linux-next.  On a regular
basis.  And have your tree in the mix, while we are at it...

Does linux-next circa the beginning of the merge window work for you?
If it doesn't, that's the starting point for git bisect you should've
run back then (or, better yet, at the time when the breakage in linux-next
only started - shorter bisect that way).

  reply	other threads:[~2016-05-26 23:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25 10:29 [PATCH 0/3] Minor orangefs xattr cleanups Andreas Gruenbacher
2016-05-25 10:29 ` [PATCH 1/3] orangefs: Remove useless defines Andreas Gruenbacher
2016-05-26 19:44   ` Mike Marshall
2016-05-26 20:05     ` Al Viro
2016-05-26 22:24       ` Mike Marshall
2016-05-26 23:53         ` Al Viro [this message]
2016-05-27 21:24           ` Mike Marshall
2016-05-28 14:25             ` Mike Marshall
2016-05-25 10:29 ` [PATCH 2/3] orangefs: Remove redundant "trusted." xattr handler Andreas Gruenbacher
2016-05-25 10:29 ` [PATCH 3/3] orangefs: Remove useless xattr prefix arguments Andreas Gruenbacher
2016-05-25 15:21 ` [PATCH 0/3] Minor orangefs xattr cleanups Mike Marshall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160526235303.GN14480@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=agruenba@redhat.com \
    --cc=hubcap@omnibond.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.