From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
devicetree@vger.kernel.org, "Rafał Miłecki" <zajec5@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
Date: Fri, 27 May 2016 15:31:53 +0200 [thread overview]
Message-ID: <20160527153153.420c86e7@bbrezillon> (raw)
In-Reply-To: <a206ce4cabf9ba8d376241fc23e9973f6db2443b.1464147910.git.baruch@tkos.co.il>
Brian,
On Wed, 25 May 2016 06:45:10 +0300
Baruch Siach <baruch@tkos.co.il> wrote:
> Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> match.
>
> Cc: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
I don't know if we should consider this as a bugfix. If that's the
case, can you take it directly in your tree with my
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Thanks,
Boris
> ---
> Documentation/devicetree/bindings/mtd/nand.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt
> index 68342eac2383..3733300de8dd 100644
> --- a/Documentation/devicetree/bindings/mtd/nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/nand.txt
> @@ -53,7 +53,8 @@ Example:
>
> nand@0 {
> reg = <0>;
> - nand-ecc-mode = "soft_bch";
> + nand-ecc-mode = "soft";
> + nand-ecc-algo = "bch";
>
> /* controller specific properties */
> };
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
Cc: "David Woodhouse" <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"Brian Norris"
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] Documentation: dt: mtd: drop "soft_bch" from example
Date: Fri, 27 May 2016 15:31:53 +0200 [thread overview]
Message-ID: <20160527153153.420c86e7@bbrezillon> (raw)
In-Reply-To: <a206ce4cabf9ba8d376241fc23e9973f6db2443b.1464147910.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
Brian,
On Wed, 25 May 2016 06:45:10 +0300
Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org> wrote:
> Commit 32698aafc9f0 (Documentation: devicetree: deprecate "soft_bch"
> nand-ecc-mode value, 2016-04-22) deprecated "soft_bch". Update the example to
> match.
>
> Cc: Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
I don't know if we should consider this as a bugfix. If that's the
case, can you take it directly in your tree with my
Acked-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Thanks,
Boris
> ---
> Documentation/devicetree/bindings/mtd/nand.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documentation/devicetree/bindings/mtd/nand.txt
> index 68342eac2383..3733300de8dd 100644
> --- a/Documentation/devicetree/bindings/mtd/nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/nand.txt
> @@ -53,7 +53,8 @@ Example:
>
> nand@0 {
> reg = <0>;
> - nand-ecc-mode = "soft_bch";
> + nand-ecc-mode = "soft";
> + nand-ecc-algo = "bch";
>
> /* controller specific properties */
> };
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-27 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 3:45 [PATCH] Documentation: dt: mtd: drop "soft_bch" from example Baruch Siach
2016-05-25 3:45 ` Baruch Siach
2016-05-25 7:26 ` Rafał Miłecki
2016-05-25 7:26 ` Rafał Miłecki
2016-05-25 19:02 ` Rob Herring
2016-05-25 19:02 ` Rob Herring
2016-05-27 13:31 ` Boris Brezillon [this message]
2016-05-27 13:31 ` Boris Brezillon
2016-05-27 16:58 ` Brian Norris
2016-05-27 16:58 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527153153.420c86e7@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=baruch@tkos.co.il \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.