* exporting kernel headers via the include/uapi directory
@ 2016-05-27 12:07 Robert P. J. Day
2016-05-27 12:33 ` Robert P. J. Day
2016-05-27 16:14 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Robert P. J. Day @ 2016-05-27 12:07 UTC (permalink / raw)
To: kernelnewbies
next question about exporting kernel headers, this one related to
the content placed under include/uapi/.
is there any rationale for header files to be living under
include/uapi/<somedir> if they're not listed in the corresponding
Kbuild file for export?
for example, in include/uapi/drm, there are 24 header files, but
only 21 of them are mentioned in that Kbuild file -- the Kbuild file
doesn't mention armada_drm.h, etnaviv_drm.h or omap_drm.h, and i've
verified that running "make headers_install" doesn't install those
three headers.
i'm going to assume those are just forgotten remnants or something,
unless there is some actual reason to do that. is there?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread* exporting kernel headers via the include/uapi directory
2016-05-27 12:07 exporting kernel headers via the include/uapi directory Robert P. J. Day
@ 2016-05-27 12:33 ` Robert P. J. Day
2016-05-27 12:59 ` Bjørn Mork
2016-05-27 16:14 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Robert P. J. Day @ 2016-05-27 12:33 UTC (permalink / raw)
To: kernelnewbies
On Fri, 27 May 2016, Robert P. J. Day wrote:
> next question about exporting kernel headers, this one related to
> the content placed under include/uapi/.
>
> is there any rationale for header files to be living under
> include/uapi/<somedir> if they're not listed in the corresponding
> Kbuild file for export?
>
> for example, in include/uapi/drm, there are 24 header files, but
> only 21 of them are mentioned in that Kbuild file -- the Kbuild file
> doesn't mention armada_drm.h, etnaviv_drm.h or omap_drm.h, and i've
> verified that running "make headers_install" doesn't install those
> three headers.
>
> i'm going to assume those are just forgotten remnants or
> something, unless there is some actual reason to do that. is there?
while i'm here, some pedantry ... what is the point of adding a
header file somewhere under include/uapi/<somedir> without
*immediately* adding it to the Kbuild file so that it's exported?
for example, i note that include/uapi/drm/amdgpu_drm.h was committed
back in april of 2015, but a "headers-y" line for it wasn't added
until nov of that same year. so what was that header file doing all
that time in between?
or is there some mechanism that allows export of UAPI header files
even if they're not mentioned in Kbuild?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread* exporting kernel headers via the include/uapi directory
2016-05-27 12:33 ` Robert P. J. Day
@ 2016-05-27 12:59 ` Bjørn Mork
2016-05-27 14:56 ` Robert P. J. Day
0 siblings, 1 reply; 6+ messages in thread
From: Bjørn Mork @ 2016-05-27 12:59 UTC (permalink / raw)
To: kernelnewbies
"Robert P. J. Day" <rpjday@crashcourse.ca> writes:
> while i'm here, some pedantry ... what is the point of adding a
> header file somewhere under include/uapi/<somedir> without
> *immediately* adding it to the Kbuild file so that it's exported?
I don't know the answer to that. But having done this once, I can
answer why *I* did it: Ignorance.
I didn't realize that I had to update the Kbuild file, but wrongly
assumed that creating a file somewhere in include/uapi was enough.
Maybe that's the reason for most of these errors? Some automatic check,
or maybe even automatic fix, would be nice. Should be pretty easy to
do.
Bj?rn
^ permalink raw reply [flat|nested] 6+ messages in thread
* exporting kernel headers via the include/uapi directory
2016-05-27 12:59 ` Bjørn Mork
@ 2016-05-27 14:56 ` Robert P. J. Day
0 siblings, 0 replies; 6+ messages in thread
From: Robert P. J. Day @ 2016-05-27 14:56 UTC (permalink / raw)
To: kernelnewbies
On Fri, 27 May 2016, Bj?rn Mork wrote:
> "Robert P. J. Day" <rpjday@crashcourse.ca> writes:
>
> > while i'm here, some pedantry ... what is the point of adding a
> > header file somewhere under include/uapi/<somedir> without
> > *immediately* adding it to the Kbuild file so that it's exported?
>
> I don't know the answer to that. But having done this once, I can
> answer why *I* did it: Ignorance.
>
> I didn't realize that I had to update the Kbuild file, but wrongly
> assumed that creating a file somewhere in include/uapi was enough.
> Maybe that's the reason for most of these errors? Some automatic
> check, or maybe even automatic fix, would be nice. Should be pretty
> easy to do.
unless there really is some reason to not do those two things at
the same time, but for the life of me, i can't imagine what it is.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* exporting kernel headers via the include/uapi directory
2016-05-27 12:07 exporting kernel headers via the include/uapi directory Robert P. J. Day
2016-05-27 12:33 ` Robert P. J. Day
@ 2016-05-27 16:14 ` Greg KH
2016-05-27 16:25 ` Robert P. J. Day
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-05-27 16:14 UTC (permalink / raw)
To: kernelnewbies
On Fri, May 27, 2016 at 08:07:17AM -0400, Robert P. J. Day wrote:
>
> next question about exporting kernel headers, this one related to
> the content placed under include/uapi/.
>
> is there any rationale for header files to be living under
> include/uapi/<somedir> if they're not listed in the corresponding
> Kbuild file for export?
>
> for example, in include/uapi/drm, there are 24 header files, but
> only 21 of them are mentioned in that Kbuild file -- the Kbuild file
> doesn't mention armada_drm.h, etnaviv_drm.h or omap_drm.h, and i've
> verified that running "make headers_install" doesn't install those
> three headers.
>
> i'm going to assume those are just forgotten remnants or something,
> unless there is some actual reason to do that. is there?
Why not ask this on the drm mailing list?
^ permalink raw reply [flat|nested] 6+ messages in thread
* exporting kernel headers via the include/uapi directory
2016-05-27 16:14 ` Greg KH
@ 2016-05-27 16:25 ` Robert P. J. Day
0 siblings, 0 replies; 6+ messages in thread
From: Robert P. J. Day @ 2016-05-27 16:25 UTC (permalink / raw)
To: kernelnewbies
On Fri, 27 May 2016, Greg KH wrote:
> On Fri, May 27, 2016 at 08:07:17AM -0400, Robert P. J. Day wrote:
> >
> > next question about exporting kernel headers, this one related to
> > the content placed under include/uapi/.
> >
> > is there any rationale for header files to be living under
> > include/uapi/<somedir> if they're not listed in the corresponding
> > Kbuild file for export?
> >
> > for example, in include/uapi/drm, there are 24 header files, but
> > only 21 of them are mentioned in that Kbuild file -- the Kbuild file
> > doesn't mention armada_drm.h, etnaviv_drm.h or omap_drm.h, and i've
> > verified that running "make headers_install" doesn't install those
> > three headers.
> >
> > i'm going to assume those are just forgotten remnants or something,
> > unless there is some actual reason to do that. is there?
>
> Why not ask this on the drm mailing list?
because drm is not the only subdirectory for which that's true, and
the question really is a generic one.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-05-27 16:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-27 12:07 exporting kernel headers via the include/uapi directory Robert P. J. Day
2016-05-27 12:33 ` Robert P. J. Day
2016-05-27 12:59 ` Bjørn Mork
2016-05-27 14:56 ` Robert P. J. Day
2016-05-27 16:14 ` Greg KH
2016-05-27 16:25 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.