From: Johannes Weiner <hannes@cmpxchg.org>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol: fix possible css ref leak on oom
Date: Fri, 27 May 2016 13:36:29 -0400 [thread overview]
Message-ID: <20160527173629.GE2531@cmpxchg.org> (raw)
In-Reply-To: <1464019330-7579-1-git-send-email-vdavydov@virtuozzo.com>
On Mon, May 23, 2016 at 07:02:10PM +0300, Vladimir Davydov wrote:
> mem_cgroup_oom may be invoked multiple times while a process is handling
> a page fault, in which case current->memcg_in_oom will be overwritten
> leaking the previously taken css reference.
There is a task_in_memcg_oom() check before calling mem_cgroup_oom().
How can this happen?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol: fix possible css ref leak on oom
Date: Fri, 27 May 2016 13:36:29 -0400 [thread overview]
Message-ID: <20160527173629.GE2531@cmpxchg.org> (raw)
In-Reply-To: <1464019330-7579-1-git-send-email-vdavydov@virtuozzo.com>
On Mon, May 23, 2016 at 07:02:10PM +0300, Vladimir Davydov wrote:
> mem_cgroup_oom may be invoked multiple times while a process is handling
> a page fault, in which case current->memcg_in_oom will be overwritten
> leaking the previously taken css reference.
There is a task_in_memcg_oom() check before calling mem_cgroup_oom().
How can this happen?
next prev parent reply other threads:[~2016-05-27 17:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 16:02 [PATCH] mm: memcontrol: fix possible css ref leak on oom Vladimir Davydov
2016-05-23 16:02 ` Vladimir Davydov
2016-05-23 17:44 ` Michal Hocko
2016-05-23 17:44 ` Michal Hocko
2016-05-24 8:43 ` Vladimir Davydov
2016-05-24 8:43 ` Vladimir Davydov
2016-05-24 8:47 ` Michal Hocko
2016-05-24 8:47 ` Michal Hocko
2016-05-24 9:01 ` Vladimir Davydov
2016-05-24 9:01 ` Vladimir Davydov
2016-05-24 9:22 ` Michal Hocko
2016-05-24 9:22 ` Michal Hocko
2016-05-24 10:05 ` Vladimir Davydov
2016-05-24 10:05 ` Vladimir Davydov
2016-05-24 11:31 ` Michal Hocko
2016-05-24 11:31 ` Michal Hocko
2016-05-27 17:36 ` Johannes Weiner [this message]
2016-05-27 17:36 ` Johannes Weiner
2016-05-29 9:11 ` Vladimir Davydov
2016-05-29 9:11 ` Vladimir Davydov
2016-05-30 7:26 ` Michal Hocko
2016-05-30 7:26 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160527173629.GE2531@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.