All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system: add comment about busybox-show-others
Date: Fri, 27 May 2016 22:59:24 +0200	[thread overview]
Message-ID: <20160527205924.GE3624@free.fr> (raw)
In-Reply-To: <20160527225012.2ed6e4e6@free-electrons.com>

Thomas, All,

On 2016-05-27 22:50 +0200, Thomas Petazzoni spake thusly:
> On Fri, 27 May 2016 22:34:51 +0200, Yann E. MORIN wrote:
> 
> >  config BR2_INIT_SYSV
> >  	bool "systemV"
> > +	# BR2_PACKAGE_BUSYBOX_SHOW_OTHERS exists even when Busybox is not enabled
> >  	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # sysvinit
> 
> Well, I don't really see the point. You can perfectly well have Busybox
> enabled *and* systemV as your init system.

I'm not arguing that.

What was puzzling me is that BR2_PACKAGE_BUSYBOX_SHOW_OTHERS *appears*
to be a Busybox option.

Package options should not be selected before ensurign that the package
itself is enabled, so we have wither:

    select BR2_PACKAGE_FOO
    select BR2_PACKAGE_FOO_OPTION

or:

    depends on BR2_PACKAGE_FOO
    select BR2_PACKAGE_FOO_OPTION

or:

    select BR2_PACKAGE_FOO_OPTION if BR2_PACKAGE_FOO

However, for this specific option, it is *also* available when Busybox
is *not* enabled: it is not a package option.

So it is perfectly legit to select it without checking that Busybix
itself is enabled.

(Yes, I lost almost 10 minutes hunting that down...)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2016-05-27 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 20:34 [Buildroot] [PATCH] system: add comment about busybox-show-others Yann E. MORIN
2016-05-27 20:50 ` Thomas Petazzoni
2016-05-27 20:59   ` Yann E. MORIN [this message]
2016-05-27 21:10     ` Thomas Petazzoni
2016-05-27 21:17       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160527205924.GE3624@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.