All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system: add comment about busybox-show-others
Date: Fri, 27 May 2016 23:10:00 +0200	[thread overview]
Message-ID: <20160527231000.56429fde@free-electrons.com> (raw)
In-Reply-To: <20160527205924.GE3624@free.fr>

Hello,

On Fri, 27 May 2016 22:59:24 +0200, Yann E. MORIN wrote:

> What was puzzling me is that BR2_PACKAGE_BUSYBOX_SHOW_OTHERS *appears*
> to be a Busybox option.
> 
> Package options should not be selected before ensurign that the package
> itself is enabled, so we have wither:
> 
>     select BR2_PACKAGE_FOO
>     select BR2_PACKAGE_FOO_OPTION
> 
> or:
> 
>     depends on BR2_PACKAGE_FOO
>     select BR2_PACKAGE_FOO_OPTION
> 
> or:
> 
>     select BR2_PACKAGE_FOO_OPTION if BR2_PACKAGE_FOO
> 
> However, for this specific option, it is *also* available when Busybox
> is *not* enabled: it is not a package option.
> 
> So it is perfectly legit to select it without checking that Busybix
> itself is enabled.

Then change the code to:

	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS if BR2_PACKAGE_BUSYBOX

Indeed, when BR2_PACKAGE_BUSYBOX is disabled,
BR2_PACKAGE_BUSYBOX_SHOW_OTHERS is *always* set to 'y'.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-05-27 21:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 20:34 [Buildroot] [PATCH] system: add comment about busybox-show-others Yann E. MORIN
2016-05-27 20:50 ` Thomas Petazzoni
2016-05-27 20:59   ` Yann E. MORIN
2016-05-27 21:10     ` Thomas Petazzoni [this message]
2016-05-27 21:17       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160527231000.56429fde@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.