From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Erico Nunes <erico.nunes@datacom.ind.br>,
kernel-janitors@vger.kernel.org, LKP <lkp@01.org>
Subject: Re: [PATCH] Revert "i2c: dev: switch from register_chrdev to cdev API"
Date: Sat, 28 May 2016 09:15:59 +0000 [thread overview]
Message-ID: <20160528091559.GR11011@mwanda> (raw)
In-Reply-To: <1464426467-1824-1-git-send-email-wsa@the-dreams.de>
On Sat, May 28, 2016 at 11:07:47AM +0200, Wolfram Sang wrote:
> This reverts commit d6760b14d4a1243f918d983bba1e35c5a5cd5a6d. When
> hitting Linus' tree, buildbots ran additional checks and found boot
> problems. Although Dan Carpenter provided an obvious fix already, I
> still could not reproduce one problem manually (at least not on a
> Saturday morning). So we'll try again later after some more
> investigation.
>
These kinds of use after frees don't always cause a runtime problem. I
found it using static analysis, but I bet you could detect it if you
enabled kasan. The other option is to enable PAGE_POISONING?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Erico Nunes <erico.nunes@datacom.ind.br>,
kernel-janitors@vger.kernel.org, LKP <lkp@01.org>
Subject: Re: [PATCH] Revert "i2c: dev: switch from register_chrdev to cdev API"
Date: Sat, 28 May 2016 12:15:59 +0300 [thread overview]
Message-ID: <20160528091559.GR11011@mwanda> (raw)
In-Reply-To: <1464426467-1824-1-git-send-email-wsa@the-dreams.de>
On Sat, May 28, 2016 at 11:07:47AM +0200, Wolfram Sang wrote:
> This reverts commit d6760b14d4a1243f918d983bba1e35c5a5cd5a6d. When
> hitting Linus' tree, buildbots ran additional checks and found boot
> problems. Although Dan Carpenter provided an obvious fix already, I
> still could not reproduce one problem manually (at least not on a
> Saturday morning). So we'll try again later after some more
> investigation.
>
These kinds of use after frees don't always cause a runtime problem. I
found it using static analysis, but I bet you could detect it if you
enabled kasan. The other option is to enable PAGE_POISONING?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: lkp@lists.01.org
Subject: Re: [PATCH] Revert "i2c: dev: switch from register_chrdev to cdev API"
Date: Sat, 28 May 2016 12:15:59 +0300 [thread overview]
Message-ID: <20160528091559.GR11011@mwanda> (raw)
In-Reply-To: <1464426467-1824-1-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Sat, May 28, 2016 at 11:07:47AM +0200, Wolfram Sang wrote:
> This reverts commit d6760b14d4a1243f918d983bba1e35c5a5cd5a6d. When
> hitting Linus' tree, buildbots ran additional checks and found boot
> problems. Although Dan Carpenter provided an obvious fix already, I
> still could not reproduce one problem manually (at least not on a
> Saturday morning). So we'll try again later after some more
> investigation.
>
These kinds of use after frees don't always cause a runtime problem. I
found it using static analysis, but I bet you could detect it if you
enabled kasan. The other option is to enable PAGE_POISONING?
regards,
dan carpenter
next prev parent reply other threads:[~2016-05-28 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 9:07 [PATCH] Revert "i2c: dev: switch from register_chrdev to cdev API" Wolfram Sang
2016-05-28 9:07 ` Wolfram Sang
2016-05-28 9:07 ` Wolfram Sang
2016-05-28 9:15 ` Dan Carpenter [this message]
2016-05-28 9:15 ` Dan Carpenter
2016-05-28 9:15 ` Dan Carpenter
2016-05-28 16:04 ` Wolfram Sang
2016-05-28 16:04 ` Wolfram Sang
2016-05-28 16:04 ` Wolfram Sang
2016-05-30 7:05 ` Dan Carpenter
2016-05-30 7:05 ` Dan Carpenter
2016-05-30 7:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160528091559.GR11011@mwanda \
--to=dan.carpenter@oracle.com \
--cc=erico.nunes@datacom.ind.br \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.