From: Thierry Reding <thierry.reding@gmail.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
srv_heupstream@mediatek.com, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Mao Huang <littlecvr@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>,
yt.shen@mediatek.com, yingjoe.chen@mediatek.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings
Date: Mon, 30 May 2016 12:45:53 +0200 [thread overview]
Message-ID: <20160530104553.GB8388@ulmo.ba.sec> (raw)
In-Reply-To: <1463996582.30093.5.camel@mtksdaap41>
[-- Attachment #1.1: Type: text/plain, Size: 1728 bytes --]
On Mon, May 23, 2016 at 05:43:02PM +0800, CK Hu wrote:
> Hi, YT:
>
> One comment below.
>
> On Fri, 2016-05-20 at 23:05 +0800, yt.shen@mediatek.com wrote:
> > From: YT Shen <yt.shen@mediatek.com>
> >
> > There are some hardware settings changed, between MT8173 & MT2701:
> > DISP_OVL address offset changed, color format definition changed.
> > DISP_RDMA fifo size changed.
> > DISP_COLOR offset changed.
> >
> > Signed-off-by: YT Shen <yt.shen@mediatek.com>
> > ---
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_ovl_get_driver_data(
> > + struct platform_device *pdev)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_device(mtk_disp_ovl_driver_dt_match, &pdev->dev);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_rdma_get_driver_data(
> > + struct platform_device *pdev)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_device(mtk_disp_rdma_driver_dt_match, &pdev->dev);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_color_get_driver_data(
> > + struct device_node *node)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_node(mtk_disp_color_driver_dt_match, node);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
>
> These three functions looks the same with different parameter:
> mtk_disp_ovl_driver_dt_match, mtk_disp_rdma_driver_dt_match, and
> mtk_disp_color_driver_dt_match. So merge them to prevent duplicated
> code.
I think what you really want is of_device_get_match_data().
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings
Date: Mon, 30 May 2016 12:45:53 +0200 [thread overview]
Message-ID: <20160530104553.GB8388@ulmo.ba.sec> (raw)
In-Reply-To: <1463996582.30093.5.camel@mtksdaap41>
On Mon, May 23, 2016 at 05:43:02PM +0800, CK Hu wrote:
> Hi, YT:
>
> One comment below.
>
> On Fri, 2016-05-20 at 23:05 +0800, yt.shen at mediatek.com wrote:
> > From: YT Shen <yt.shen@mediatek.com>
> >
> > There are some hardware settings changed, between MT8173 & MT2701:
> > DISP_OVL address offset changed, color format definition changed.
> > DISP_RDMA fifo size changed.
> > DISP_COLOR offset changed.
> >
> > Signed-off-by: YT Shen <yt.shen@mediatek.com>
> > ---
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_ovl_get_driver_data(
> > + struct platform_device *pdev)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_device(mtk_disp_ovl_driver_dt_match, &pdev->dev);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_rdma_get_driver_data(
> > + struct platform_device *pdev)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_device(mtk_disp_rdma_driver_dt_match, &pdev->dev);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_color_get_driver_data(
> > + struct device_node *node)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_node(mtk_disp_color_driver_dt_match, node);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
>
> These three functions looks the same with different parameter:
> mtk_disp_ovl_driver_dt_match, mtk_disp_rdma_driver_dt_match, and
> mtk_disp_color_driver_dt_match. So merge them to prevent duplicated
> code.
I think what you really want is of_device_get_match_data().
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160530/a7d0433e/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: yt.shen@mediatek.com, Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Mao Huang <littlecvr@chromium.org>,
srv_heupstream@mediatek.com, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
yingjoe.chen@mediatek.com, Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings
Date: Mon, 30 May 2016 12:45:53 +0200 [thread overview]
Message-ID: <20160530104553.GB8388@ulmo.ba.sec> (raw)
In-Reply-To: <1463996582.30093.5.camel@mtksdaap41>
[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]
On Mon, May 23, 2016 at 05:43:02PM +0800, CK Hu wrote:
> Hi, YT:
>
> One comment below.
>
> On Fri, 2016-05-20 at 23:05 +0800, yt.shen@mediatek.com wrote:
> > From: YT Shen <yt.shen@mediatek.com>
> >
> > There are some hardware settings changed, between MT8173 & MT2701:
> > DISP_OVL address offset changed, color format definition changed.
> > DISP_RDMA fifo size changed.
> > DISP_COLOR offset changed.
> >
> > Signed-off-by: YT Shen <yt.shen@mediatek.com>
> > ---
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_ovl_get_driver_data(
> > + struct platform_device *pdev)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_device(mtk_disp_ovl_driver_dt_match, &pdev->dev);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_rdma_get_driver_data(
> > + struct platform_device *pdev)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_device(mtk_disp_rdma_driver_dt_match, &pdev->dev);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
> > +static inline struct mtk_ddp_comp_driver_data *mtk_color_get_driver_data(
> > + struct device_node *node)
> > +{
> > + const struct of_device_id *of_id =
> > + of_match_node(mtk_disp_color_driver_dt_match, node);
> > +
> > + return (struct mtk_ddp_comp_driver_data *)of_id->data;
> > +}
> > +
>
> These three functions looks the same with different parameter:
> mtk_disp_ovl_driver_dt_match, mtk_disp_rdma_driver_dt_match, and
> mtk_disp_color_driver_dt_match. So merge them to prevent duplicated
> code.
I think what you really want is of_device_get_match_data().
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-30 10:45 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 15:05 [RFC v2 0/5] MT2701 DRM support yt.shen
2016-05-20 15:05 ` yt.shen
2016-05-20 15:05 ` yt.shen at mediatek.com
2016-05-20 15:05 ` [RFC v2 1/5] drm/mediatek: rename macros, add chip suffix yt.shen
2016-05-20 15:05 ` yt.shen
2016-05-20 15:05 ` yt.shen at mediatek.com
2016-05-27 9:30 ` Emil Velikov
2016-05-27 9:30 ` Emil Velikov
2016-05-27 9:30 ` Emil Velikov
2016-05-30 10:23 ` YT Shen
2016-05-30 10:23 ` YT Shen
2016-05-30 10:23 ` YT Shen
2016-05-30 10:41 ` Thierry Reding
2016-05-30 10:41 ` Thierry Reding
2016-06-01 9:09 ` YT Shen
2016-06-01 9:09 ` YT Shen
2016-06-01 9:09 ` YT Shen
2016-05-20 15:05 ` [RFC v2 2/5] drm/mediatke: add support for Mediatek SoC MT2701 yt.shen
2016-05-20 15:05 ` yt.shen
2016-05-20 15:05 ` yt.shen at mediatek.com
[not found] ` <1463756736-46573-3-git-send-email-yt.shen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-05-23 9:09 ` CK Hu
2016-05-23 9:09 ` CK Hu
2016-05-23 9:09 ` CK Hu
2016-05-27 7:29 ` YT Shen
2016-05-27 7:29 ` YT Shen
2016-05-27 7:29 ` YT Shen
2016-05-27 9:35 ` Emil Velikov
2016-05-27 9:35 ` Emil Velikov
2016-05-27 9:35 ` Emil Velikov
2016-05-30 10:24 ` YT Shen
2016-05-30 10:24 ` YT Shen
2016-05-30 10:24 ` YT Shen
2016-05-20 15:05 ` [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings yt.shen
2016-05-20 15:05 ` yt.shen
2016-05-20 15:05 ` yt.shen at mediatek.com
2016-05-23 9:43 ` CK Hu
2016-05-23 9:43 ` CK Hu
2016-05-23 9:43 ` CK Hu
2016-05-27 7:31 ` YT Shen
2016-05-27 7:31 ` YT Shen
2016-05-27 7:31 ` YT Shen
2016-05-27 9:24 ` Emil Velikov
2016-05-27 9:24 ` Emil Velikov
2016-05-27 9:24 ` Emil Velikov
2016-05-30 10:26 ` YT Shen
2016-05-30 10:26 ` YT Shen
2016-05-30 10:26 ` YT Shen
2016-05-30 10:45 ` Thierry Reding [this message]
2016-05-30 10:45 ` Thierry Reding
2016-05-30 10:45 ` Thierry Reding
2016-06-01 9:10 ` YT Shen
2016-06-01 9:10 ` YT Shen
2016-06-01 9:10 ` YT Shen
2016-05-20 15:05 ` [RFC v2 4/5] drm/mediatek: add shadow register support yt.shen
2016-05-20 15:05 ` yt.shen
2016-05-20 15:05 ` yt.shen at mediatek.com
2016-05-20 15:05 ` [RFC v2 5/5] arm: dts: mt2701: Add display subsystem related nodes for MT2701 yt.shen
2016-05-20 15:05 ` yt.shen
2016-05-20 15:05 ` yt.shen at mediatek.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160530104553.GB8388@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=littlecvr@chromium.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.