From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements
Date: Tue, 31 May 2016 08:30:22 +0100 [thread overview]
Message-ID: <20160531073022.GA1729@dell> (raw)
In-Reply-To: <9716c1c8-dd2b-8444-6ec9-567d07fe8971-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Fri, 27 May 2016, Rhyland Klein wrote:
> On 5/12/2016 1:52 PM, Laxman Dewangan wrote:
> >
> > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote:
> >> When configuring FPS during probe, assuming a DT node is present for
> >> FPS, the code can run into a problem with the switch statements in
> >> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
> >> in the case of chip->chip_id == MAX77620, it will set
> >> fps_[mix|max]_period but then fall through to the default switch case
> >> and return -EINVAL. Returning this from max77620_config_fps() will
> >> cause probe to fail.
> >>
> >
> > Thanks for fixes.
> > Missed when converting if-else to switch.
> >
> > Reviewed-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >
>
> Lee, I noticed this hasn't been merged yet, but without it platforms
> using the max77620 can easily (if it has FPS nodes) fail to probe. Is
> there anything blocking it?
Yes, it was sent too late in the cycle.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements
Date: Tue, 31 May 2016 08:30:22 +0100 [thread overview]
Message-ID: <20160531073022.GA1729@dell> (raw)
In-Reply-To: <9716c1c8-dd2b-8444-6ec9-567d07fe8971@nvidia.com>
On Fri, 27 May 2016, Rhyland Klein wrote:
> On 5/12/2016 1:52 PM, Laxman Dewangan wrote:
> >
> > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote:
> >> When configuring FPS during probe, assuming a DT node is present for
> >> FPS, the code can run into a problem with the switch statements in
> >> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
> >> in the case of chip->chip_id == MAX77620, it will set
> >> fps_[mix|max]_period but then fall through to the default switch case
> >> and return -EINVAL. Returning this from max77620_config_fps() will
> >> cause probe to fail.
> >>
> >
> > Thanks for fixes.
> > Missed when converting if-else to switch.
> >
> > Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
> >
>
> Lee, I noticed this hasn't been merged yet, but without it platforms
> using the max77620 can easily (if it has FPS nodes) fail to probe. Is
> there anything blocking it?
Yes, it was sent too late in the cycle.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-05-31 7:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 17:45 [PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein
2016-05-12 17:45 ` Rhyland Klein
2016-05-12 17:52 ` Laxman Dewangan
2016-05-12 17:52 ` Laxman Dewangan
2016-05-27 20:31 ` Rhyland Klein
2016-05-27 20:31 ` Rhyland Klein
[not found] ` <9716c1c8-dd2b-8444-6ec9-567d07fe8971-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-31 7:30 ` Lee Jones [this message]
2016-05-31 7:30 ` Lee Jones
2016-06-01 15:29 ` Rhyland Klein
2016-06-01 15:29 ` Rhyland Klein
2016-06-06 15:32 ` Thierry Reding
2016-06-06 15:32 ` Thierry Reding
2016-06-07 8:05 ` Lee Jones
2016-06-14 16:50 ` Rhyland Klein
2016-06-14 16:50 ` Rhyland Klein
2016-06-15 6:11 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531073022.GA1729@dell \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.