* mwifiex: fix self-assignment in mwifiex_uap_recv_packet
@ 2016-05-31 15:16 Dave Jones
2016-05-31 15:23 ` Amitkumar Karwar
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2016-05-31 15:16 UTC (permalink / raw)
To: Linux Kernel; +Cc: Xinming Hu, Cathy Luo, Amitkumar Karwar, Kalle Valo
This function wants to operate on the adapter pointer in the priv
struct, not on itself which makes no sense.
Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
index 666e91af59d7..bf5660eb27d3 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
@@ -272,7 +272,7 @@ int mwifiex_handle_uap_rx_forward(struct mwifiex_private *priv,
int mwifiex_uap_recv_packet(struct mwifiex_private *priv,
struct sk_buff *skb)
{
- struct mwifiex_adapter *adapter = adapter;
+ struct mwifiex_adapter *adapter = priv->adapter;
struct mwifiex_sta_node *src_node;
struct ethhdr *p_ethhdr;
struct sk_buff *skb_uap;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: mwifiex: fix self-assignment in mwifiex_uap_recv_packet
2016-05-31 15:16 mwifiex: fix self-assignment in mwifiex_uap_recv_packet Dave Jones
@ 2016-05-31 15:23 ` Amitkumar Karwar
0 siblings, 0 replies; 2+ messages in thread
From: Amitkumar Karwar @ 2016-05-31 15:23 UTC (permalink / raw)
To: Dave Jones, Linux Kernel; +Cc: Xinming Hu, Cathy Luo, Kalle Valo
Hi Dave,
> From: Dave Jones [mailto:davej@codemonkey.org.uk]
> Sent: Tuesday, May 31, 2016 8:47 PM
> To: Linux Kernel
> Cc: Xinming Hu; Cathy Luo; Amitkumar Karwar; Kalle Valo
> Subject: mwifiex: fix self-assignment in mwifiex_uap_recv_packet
>
> This function wants to operate on the adapter pointer in the priv
> struct, not on itself which makes no sense.
>
> Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> index 666e91af59d7..bf5660eb27d3 100644
> --- a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> +++ b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> @@ -272,7 +272,7 @@ int mwifiex_handle_uap_rx_forward(struct
> mwifiex_private *priv, int mwifiex_uap_recv_packet(struct
> mwifiex_private *priv,
> struct sk_buff *skb)
> {
> - struct mwifiex_adapter *adapter = adapter;
> + struct mwifiex_adapter *adapter = priv->adapter;
> struct mwifiex_sta_node *src_node;
> struct ethhdr *p_ethhdr;
> struct sk_buff *skb_uap;
Thanks for the patch. This has been already taken cared by below patch submitted recently.
https://patchwork.kernel.org/patch/9115501/
Regards,
Amitkumar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-31 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-31 15:16 mwifiex: fix self-assignment in mwifiex_uap_recv_packet Dave Jones
2016-05-31 15:23 ` Amitkumar Karwar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.