From: Mike Snitzer <snitzer@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"open list:DRBD DRIVER" <drbd-dev@lists.linbit.com>,
Jan Kara <jack@suse.cz>, Joe Thornber <ejt@redhat.com>,
Keith Busch <keith.busch@intel.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Michal Hocko <mhocko@suse.com>, NeilBrown <neilb@suse.com>,
Sagi Grimberg <sagig@mellanox.com>, Shaohua Li <shli@fb.com>,
Steven Whitehouse <swhiteho@redhat.com>,
Tejun Heo <tj@kernel.org>,
"open list:XFS FILESYSTEM" <xfs@oss.sgi.com>
Subject: Re: [PATCH v6 0/8] block: prepare for multipage bvecs
Date: Tue, 31 May 2016 11:53:49 -0400 [thread overview]
Message-ID: <20160531155348.GA24840@redhat.com> (raw)
In-Reply-To: <1464615294-9946-1-git-send-email-ming.lei@canonical.com>
On Mon, May 30 2016 at 9:34am -0400,
Ming Lei <ming.lei@canonical.com> wrote:
>
> Hi,
>
> Interests[1] have been shown in multipage bvecs, so this patchset
> try to prepare for the support and do two things:
>
> 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(),
> then we can drop the non-standard way for iterating bvec, which
> can be thought as a good cleanup for lib/iov_iter.c
>
> 2) remove BIO_MAX_SECTORS and makre BIO_MAX_SIZE as obsolete, and
> now there is only one user for each. Once multipage bvecs is introduced,
> one bio may hold lots of sectors, and we should always use sort of
> BIO_MAX_VECS which should be introduced in future and is similiar
> with current BIO_MAX_PAGES.
>
> The only functional change is iterate_bvec():lib/iov_iter.c
>
> xfstests(-a auto) over loop aio is run for ext4/xfs to verify
> the change and no regression found with this patchset.
>
> V6:
> - rebased on v4.7-rc1
> - add reviewed-by tag
> - mark BIO_MAX_SIZE as obsolete instead of removing because
> dm-tree adds one usage now
Not sure what you're referring to here with "dm-tree" (since "dm-tree"
doesn't exist). But only direct user of "BIO_MAX_SIZE" in DM appears to
be dm-crypt.c. Maybe you've identified some indirect use of
BIO_MAX_SIZE?
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-block@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
Jan Kara <jack@suse.cz>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Steven Whitehouse <swhiteho@redhat.com>,
linux-kernel@vger.kernel.org, Sagi Grimberg <sagig@mellanox.com>,
NeilBrown <neilb@suse.com>, Jens Axboe <axboe@fb.com>,
Joe Thornber <ejt@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
Shaohua Li <shli@fb.com>, Tejun Heo <tj@kernel.org>,
Keith Busch <keith.busch@intel.com>,
"open list:XFS FILESYSTEM" <xfs@oss.sgi.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"open list:DRBD DRIVER" <drbd-dev@lists.linbit.com>
Subject: Re: [PATCH v6 0/8] block: prepare for multipage bvecs
Date: Tue, 31 May 2016 11:53:49 -0400 [thread overview]
Message-ID: <20160531155348.GA24840@redhat.com> (raw)
In-Reply-To: <1464615294-9946-1-git-send-email-ming.lei@canonical.com>
On Mon, May 30 2016 at 9:34am -0400,
Ming Lei <ming.lei@canonical.com> wrote:
>
> Hi,
>
> Interests[1] have been shown in multipage bvecs, so this patchset
> try to prepare for the support and do two things:
>
> 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(),
> then we can drop the non-standard way for iterating bvec, which
> can be thought as a good cleanup for lib/iov_iter.c
>
> 2) remove BIO_MAX_SECTORS and makre BIO_MAX_SIZE as obsolete, and
> now there is only one user for each. Once multipage bvecs is introduced,
> one bio may hold lots of sectors, and we should always use sort of
> BIO_MAX_VECS which should be introduced in future and is similiar
> with current BIO_MAX_PAGES.
>
> The only functional change is iterate_bvec():lib/iov_iter.c
>
> xfstests(-a auto) over loop aio is run for ext4/xfs to verify
> the change and no regression found with this patchset.
>
> V6:
> - rebased on v4.7-rc1
> - add reviewed-by tag
> - mark BIO_MAX_SIZE as obsolete instead of removing because
> dm-tree adds one usage now
Not sure what you're referring to here with "dm-tree" (since "dm-tree"
doesn't exist). But only direct user of "BIO_MAX_SIZE" in DM appears to
be dm-crypt.c. Maybe you've identified some indirect use of
BIO_MAX_SIZE?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: linux-block@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
Jan Kara <jack@suse.cz>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Steven Whitehouse <swhiteho@redhat.com>,
linux-kernel@vger.kernel.org, Sagi Grimberg <sagig@mellanox.com>,
NeilBrown <neilb@suse.com>, Jens Axboe <axboe@fb.com>,
Joe Thornber <ejt@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
Shaohua Li <shli@fb.com>, Tejun Heo <tj@kernel.org>,
Keith Busch <keith.busch@intel.com>,
"open list:XFS FILESYSTEM" <xfs@oss.sgi.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"open list:DRBD DRIVER" <drbd-dev@lists.linbit.com>
Subject: Re: [Drbd-dev] [PATCH v6 0/8] block: prepare for multipage bvecs
Date: Tue, 31 May 2016 11:53:49 -0400 [thread overview]
Message-ID: <20160531155348.GA24840@redhat.com> (raw)
In-Reply-To: <1464615294-9946-1-git-send-email-ming.lei@canonical.com>
On Mon, May 30 2016 at 9:34am -0400,
Ming Lei <ming.lei@canonical.com> wrote:
>
> Hi,
>
> Interests[1] have been shown in multipage bvecs, so this patchset
> try to prepare for the support and do two things:
>
> 1) the 1st 4 patches use bvec iterator to implement iterate_bvec(),
> then we can drop the non-standard way for iterating bvec, which
> can be thought as a good cleanup for lib/iov_iter.c
>
> 2) remove BIO_MAX_SECTORS and makre BIO_MAX_SIZE as obsolete, and
> now there is only one user for each. Once multipage bvecs is introduced,
> one bio may hold lots of sectors, and we should always use sort of
> BIO_MAX_VECS which should be introduced in future and is similiar
> with current BIO_MAX_PAGES.
>
> The only functional change is iterate_bvec():lib/iov_iter.c
>
> xfstests(-a auto) over loop aio is run for ext4/xfs to verify
> the change and no regression found with this patchset.
>
> V6:
> - rebased on v4.7-rc1
> - add reviewed-by tag
> - mark BIO_MAX_SIZE as obsolete instead of removing because
> dm-tree adds one usage now
Not sure what you're referring to here with "dm-tree" (since "dm-tree"
doesn't exist). But only direct user of "BIO_MAX_SIZE" in DM appears to
be dm-crypt.c. Maybe you've identified some indirect use of
BIO_MAX_SIZE?
next prev parent reply other threads:[~2016-05-31 15:53 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 13:34 [PATCH v6 0/8] block: prepare for multipage bvecs Ming Lei
2016-05-30 13:34 ` [Drbd-dev] " Ming Lei
2016-05-30 13:34 ` Ming Lei
2016-05-30 13:34 ` [PATCH v6 1/8] block: move bvec iterator into include/linux/bvec.h Ming Lei
2016-05-30 13:34 ` [PATCH v6 2/8] block: move two bvec structure into bvec.h Ming Lei
2016-05-30 13:34 ` [PATCH v6 3/8] block: mark 1st parameter of bvec_iter_advance as const Ming Lei
2016-05-30 13:34 ` [PATCH v6 4/8] iov_iter: use bvec iterator to implement iterate_bvec() Ming Lei
2016-05-30 13:34 ` [PATCH v6 5/8] fs: xfs: replace BIO_MAX_SECTORS with BIO_MAX_PAGES Ming Lei
2016-05-30 13:34 ` Ming Lei
2016-06-01 13:48 ` Christoph Hellwig
2016-06-01 13:48 ` Christoph Hellwig
2016-06-02 3:32 ` Ming Lei
2016-06-02 3:32 ` Ming Lei
2016-05-30 13:34 ` [PATCH v6 6/8] block: bio: remove BIO_MAX_SECTORS Ming Lei
2016-05-30 13:34 ` [PATCH v6 7/8] block: drbd: avoid to use BIO_MAX_SIZE Ming Lei
2016-05-30 13:34 ` [Drbd-dev] " Ming Lei
2016-05-30 13:34 ` [PATCH v6 8/8] block: mark BIO_MAX_SIZE as obsolete Ming Lei
2016-05-31 16:07 ` Jens Axboe
2016-05-31 15:53 ` Mike Snitzer [this message]
2016-05-31 15:53 ` [Drbd-dev] [PATCH v6 0/8] block: prepare for multipage bvecs Mike Snitzer
2016-05-31 15:53 ` Mike Snitzer
2016-06-01 12:38 ` Ming Lei
2016-06-01 12:38 ` [Drbd-dev] " Ming Lei
2016-06-01 12:38 ` Ming Lei
2016-06-01 13:44 ` Christoph Hellwig
2016-06-01 13:44 ` [Drbd-dev] " Christoph Hellwig
2016-06-01 13:44 ` Christoph Hellwig
2016-06-01 13:51 ` Mike Snitzer
2016-06-01 13:51 ` [Drbd-dev] " Mike Snitzer
2016-06-01 13:51 ` Mike Snitzer
2016-06-01 14:05 ` Christoph Hellwig
2016-06-01 14:05 ` [Drbd-dev] " Christoph Hellwig
2016-06-01 14:05 ` Christoph Hellwig
2016-06-02 2:13 ` Ming Lei
2016-06-02 2:13 ` [Drbd-dev] " Ming Lei
2016-06-02 2:13 ` Ming Lei
2016-06-01 13:43 ` Christoph Hellwig
2016-06-01 13:43 ` [Drbd-dev] " Christoph Hellwig
2016-06-01 13:43 ` Christoph Hellwig
2016-06-01 13:53 ` Hannes Reinecke
2016-06-01 13:53 ` Hannes Reinecke
2016-06-01 13:53 ` [Drbd-dev] " Hannes Reinecke
2016-06-01 13:53 ` Hannes Reinecke
2016-06-01 13:57 ` Mike Snitzer
2016-06-01 13:57 ` [Drbd-dev] " Mike Snitzer
2016-06-01 13:57 ` Mike Snitzer
2016-06-09 16:06 ` Jens Axboe
2016-06-09 16:06 ` [Drbd-dev] " Jens Axboe
2016-06-09 16:06 ` Jens Axboe
2016-06-10 2:44 ` Ming Lei
2016-06-10 2:44 ` [Drbd-dev] " Ming Lei
2016-06-10 2:44 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531155348.GA24840@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@fb.com \
--cc=drbd-dev@lists.linbit.com \
--cc=ejt@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=keith.busch@intel.com \
--cc=kent.overstreet@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mhocko@suse.com \
--cc=ming.lei@canonical.com \
--cc=neilb@suse.com \
--cc=sagig@mellanox.com \
--cc=shli@fb.com \
--cc=swhiteho@redhat.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.