* [PATCH] xen/Makefile: quote HOSTCC and HOSTCXX args
@ 2016-05-31 15:13 Chris Patterson
2016-05-31 16:22 ` Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Chris Patterson @ 2016-05-31 15:13 UTC (permalink / raw)
To: xen-devel
Cc: sstabellini, wei.liu2, George.Dunlap, andrew.cooper3, ian.jackson,
Chris Patterson, jbeulich, im
From: Chris Patterson <pattersonc@ainfosec.com>
In some cross-compilation environments, the CC/CXX variables may
expand out to more than one argument (to include things
like --sysroot=...). Quote these to safely pass along.
Signed-off-by: Chris Patterson <pattersonc@ainfosec.com>
---
xen/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/Makefile b/xen/Makefile
index 0d5f240..b59f95d 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -246,14 +246,14 @@ kconfig := silentoldconfig oldconfig config menuconfig defconfig \
randconfig
.PHONY: $(kconfig)
$(kconfig):
- $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) $@
+ $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@
include/config/%.conf: include/config/auto.conf.cmd $(KCONFIG_CONFIG)
- $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) silentoldconfig
+ $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" silentoldconfig
# Allow people to just run `make` as before and not force them to configure
$(KCONFIG_CONFIG):
- $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) defconfig
+ $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" defconfig
# Break the dependency chain for the first run
include/config/auto.conf.cmd: ;
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/Makefile: quote HOSTCC and HOSTCXX args
2016-05-31 15:13 [PATCH] xen/Makefile: quote HOSTCC and HOSTCXX args Chris Patterson
@ 2016-05-31 16:22 ` Jan Beulich
2016-05-31 17:45 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2016-05-31 16:22 UTC (permalink / raw)
To: wei.liu2, Chris Patterson
Cc: Chris Patterson, George.Dunlap, andrew.cooper3, ian.jackson,
xen-devel, sstabellini, im
>>> On 31.05.16 at 17:13, <cjp256@gmail.com> wrote:
> From: Chris Patterson <pattersonc@ainfosec.com>
>
> In some cross-compilation environments, the CC/CXX variables may
> expand out to more than one argument (to include things
> like --sysroot=...). Quote these to safely pass along.
>
> Signed-off-by: Chris Patterson <pattersonc@ainfosec.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Wei, do we want this in 4.7?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/Makefile: quote HOSTCC and HOSTCXX args
2016-05-31 16:22 ` Jan Beulich
@ 2016-05-31 17:45 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-05-31 17:45 UTC (permalink / raw)
To: Jan Beulich
Cc: Chris Patterson, wei.liu2, George.Dunlap, andrew.cooper3,
Chris Patterson, ian.jackson, xen-devel, sstabellini, im
On Tue, May 31, 2016 at 10:22:41AM -0600, Jan Beulich wrote:
> >>> On 31.05.16 at 17:13, <cjp256@gmail.com> wrote:
> > From: Chris Patterson <pattersonc@ainfosec.com>
> >
> > In some cross-compilation environments, the CC/CXX variables may
> > expand out to more than one argument (to include things
> > like --sysroot=...). Quote these to safely pass along.
> >
> > Signed-off-by: Chris Patterson <pattersonc@ainfosec.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> Wei, do we want this in 4.7?
Yes.
I've queued this up.
Wei.
>
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-31 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-31 15:13 [PATCH] xen/Makefile: quote HOSTCC and HOSTCXX args Chris Patterson
2016-05-31 16:22 ` Jan Beulich
2016-05-31 17:45 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.