All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] IB/hfi1: fix some indenting
@ 2016-05-28  5:01 ` Dan Carpenter
  0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2016-05-28  5:01 UTC (permalink / raw)
  To: Mike Marciniszyn
  Cc: Dennis Dalessandro, Doug Ledford, Sean Hefty, Hal Rosenstock,
	linux-rdma, linux-kernel, kernel-janitors

That extra tabs are misleading.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
index 5cc492e..0d28a5a 100644
--- a/drivers/infiniband/hw/hfi1/init.c
+++ b/drivers/infiniband/hw/hfi1/init.c
@@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
 		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
 				  (void *)dd->rcvhdrtail_dummy_kvaddr,
 				  dd->rcvhdrtail_dummy_physaddr);
-				  dd->rcvhdrtail_dummy_kvaddr = NULL;
+		dd->rcvhdrtail_dummy_kvaddr = NULL;
 	}
 
 	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [patch] IB/hfi1: fix some indenting
@ 2016-05-28  5:01 ` Dan Carpenter
  0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2016-05-28  5:01 UTC (permalink / raw)
  To: Mike Marciniszyn
  Cc: Dennis Dalessandro, Doug Ledford, Sean Hefty, Hal Rosenstock,
	linux-rdma, linux-kernel, kernel-janitors

That extra tabs are misleading.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
index 5cc492e..0d28a5a 100644
--- a/drivers/infiniband/hw/hfi1/init.c
+++ b/drivers/infiniband/hw/hfi1/init.c
@@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
 		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
 				  (void *)dd->rcvhdrtail_dummy_kvaddr,
 				  dd->rcvhdrtail_dummy_physaddr);
-				  dd->rcvhdrtail_dummy_kvaddr = NULL;
+		dd->rcvhdrtail_dummy_kvaddr = NULL;
 	}
 
 	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [patch] IB/hfi1: fix some indenting
  2016-05-28  5:01 ` Dan Carpenter
  (?)
@ 2016-05-31 18:06   ` Bart Van Assche
  -1 siblings, 0 replies; 9+ messages in thread
From: Bart Van Assche @ 2016-05-31 18:06 UTC (permalink / raw)
  To: Dan Carpenter, Mike Marciniszyn
  Cc: Dennis Dalessandro, Doug Ledford, Sean Hefty, Hal Rosenstock,
	linux-rdma, linux-kernel, kernel-janitors

On 05/27/2016 10:01 PM, Dan Carpenter wrote:
> That extra tabs are misleading.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
> index 5cc492e..0d28a5a 100644
> --- a/drivers/infiniband/hw/hfi1/init.c
> +++ b/drivers/infiniband/hw/hfi1/init.c
> @@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
>  		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
>  				  (void *)dd->rcvhdrtail_dummy_kvaddr,
>  				  dd->rcvhdrtail_dummy_physaddr);
> -				  dd->rcvhdrtail_dummy_kvaddr = NULL;
> +		dd->rcvhdrtail_dummy_kvaddr = NULL;
>  	}
>
>  	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [patch] IB/hfi1: fix some indenting
@ 2016-05-31 18:06   ` Bart Van Assche
  0 siblings, 0 replies; 9+ messages in thread
From: Bart Van Assche @ 2016-05-31 18:06 UTC (permalink / raw)
  To: Dan Carpenter, Mike Marciniszyn
  Cc: Dennis Dalessandro, Doug Ledford, Sean Hefty, Hal Rosenstock,
	linux-rdma, linux-kernel, kernel-janitors

On 05/27/2016 10:01 PM, Dan Carpenter wrote:
> That extra tabs are misleading.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
> index 5cc492e..0d28a5a 100644
> --- a/drivers/infiniband/hw/hfi1/init.c
> +++ b/drivers/infiniband/hw/hfi1/init.c
> @@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
>  		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
>  				  (void *)dd->rcvhdrtail_dummy_kvaddr,
>  				  dd->rcvhdrtail_dummy_physaddr);
> -				  dd->rcvhdrtail_dummy_kvaddr = NULL;
> +		dd->rcvhdrtail_dummy_kvaddr = NULL;
>  	}
>
>  	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [patch] IB/hfi1: fix some indenting
@ 2016-05-31 18:06   ` Bart Van Assche
  0 siblings, 0 replies; 9+ messages in thread
From: Bart Van Assche @ 2016-05-31 18:06 UTC (permalink / raw)
  To: Dan Carpenter, Mike Marciniszyn
  Cc: Dennis Dalessandro, Doug Ledford, Sean Hefty, Hal Rosenstock,
	linux-rdma, linux-kernel, kernel-janitors

On 05/27/2016 10:01 PM, Dan Carpenter wrote:
> That extra tabs are misleading.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
> index 5cc492e..0d28a5a 100644
> --- a/drivers/infiniband/hw/hfi1/init.c
> +++ b/drivers/infiniband/hw/hfi1/init.c
> @@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
>  		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
>  				  (void *)dd->rcvhdrtail_dummy_kvaddr,
>  				  dd->rcvhdrtail_dummy_physaddr);
> -				  dd->rcvhdrtail_dummy_kvaddr = NULL;
> +		dd->rcvhdrtail_dummy_kvaddr = NULL;
>  	}
>
>  	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [patch] IB/hfi1: fix some indenting
  2016-05-28  5:01 ` Dan Carpenter
@ 2016-06-01 13:40   ` Dennis Dalessandro
  -1 siblings, 0 replies; 9+ messages in thread
From: Dennis Dalessandro @ 2016-06-01 13:40 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
	linux-rdma, linux-kernel, kernel-janitors

On Sat, May 28, 2016 at 08:01:20AM +0300, Dan Carpenter wrote:
>That extra tabs are misleading.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
>index 5cc492e..0d28a5a 100644
>--- a/drivers/infiniband/hw/hfi1/init.c
>+++ b/drivers/infiniband/hw/hfi1/init.c
>@@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
> 		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
> 				  (void *)dd->rcvhdrtail_dummy_kvaddr,
> 				  dd->rcvhdrtail_dummy_physaddr);
>-				  dd->rcvhdrtail_dummy_kvaddr = NULL;
>+		dd->rcvhdrtail_dummy_kvaddr = NULL;
> 	}
> 
> 	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {

Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [patch] IB/hfi1: fix some indenting
@ 2016-06-01 13:40   ` Dennis Dalessandro
  0 siblings, 0 replies; 9+ messages in thread
From: Dennis Dalessandro @ 2016-06-01 13:40 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
	linux-rdma, linux-kernel, kernel-janitors

On Sat, May 28, 2016 at 08:01:20AM +0300, Dan Carpenter wrote:
>That extra tabs are misleading.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
>index 5cc492e..0d28a5a 100644
>--- a/drivers/infiniband/hw/hfi1/init.c
>+++ b/drivers/infiniband/hw/hfi1/init.c
>@@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
> 		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
> 				  (void *)dd->rcvhdrtail_dummy_kvaddr,
> 				  dd->rcvhdrtail_dummy_physaddr);
>-				  dd->rcvhdrtail_dummy_kvaddr = NULL;
>+		dd->rcvhdrtail_dummy_kvaddr = NULL;
> 	}
> 
> 	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {

Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [patch] IB/hfi1: fix some indenting
  2016-05-28  5:01 ` Dan Carpenter
@ 2016-06-06 23:15   ` Doug Ledford
  -1 siblings, 0 replies; 9+ messages in thread
From: Doug Ledford @ 2016-06-06 23:15 UTC (permalink / raw)
  To: Dan Carpenter, Mike Marciniszyn
  Cc: Dennis Dalessandro, Sean Hefty, Hal Rosenstock, linux-rdma,
	linux-kernel, kernel-janitors


[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]

On 5/28/2016 1:01 AM, Dan Carpenter wrote:
> That extra tabs are misleading.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
> index 5cc492e..0d28a5a 100644
> --- a/drivers/infiniband/hw/hfi1/init.c
> +++ b/drivers/infiniband/hw/hfi1/init.c
> @@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
>  		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
>  				  (void *)dd->rcvhdrtail_dummy_kvaddr,
>  				  dd->rcvhdrtail_dummy_physaddr);
> -				  dd->rcvhdrtail_dummy_kvaddr = NULL;
> +		dd->rcvhdrtail_dummy_kvaddr = NULL;
>  	}
>  
>  	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {
> 

Thanks, applied.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [patch] IB/hfi1: fix some indenting
@ 2016-06-06 23:15   ` Doug Ledford
  0 siblings, 0 replies; 9+ messages in thread
From: Doug Ledford @ 2016-06-06 23:15 UTC (permalink / raw)
  To: Dan Carpenter, Mike Marciniszyn
  Cc: Dennis Dalessandro, Sean Hefty, Hal Rosenstock, linux-rdma,
	linux-kernel, kernel-janitors


[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]

On 5/28/2016 1:01 AM, Dan Carpenter wrote:
> That extra tabs are misleading.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
> index 5cc492e..0d28a5a 100644
> --- a/drivers/infiniband/hw/hfi1/init.c
> +++ b/drivers/infiniband/hw/hfi1/init.c
> @@ -1337,7 +1337,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd)
>  		dma_free_coherent(&dd->pcidev->dev, sizeof(u64),
>  				  (void *)dd->rcvhdrtail_dummy_kvaddr,
>  				  dd->rcvhdrtail_dummy_physaddr);
> -				  dd->rcvhdrtail_dummy_kvaddr = NULL;
> +		dd->rcvhdrtail_dummy_kvaddr = NULL;
>  	}
>  
>  	for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) {
> 

Thanks, applied.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-06-06 23:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-28  5:01 [patch] IB/hfi1: fix some indenting Dan Carpenter
2016-05-28  5:01 ` Dan Carpenter
2016-05-31 18:06 ` Bart Van Assche
2016-05-31 18:06   ` Bart Van Assche
2016-05-31 18:06   ` Bart Van Assche
2016-06-01 13:40 ` Dennis Dalessandro
2016-06-01 13:40   ` Dennis Dalessandro
2016-06-06 23:15 ` Doug Ledford
2016-06-06 23:15   ` Doug Ledford

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.