From: Yuyang Du <yuyang.du@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Benjamin Segall <bsegall@google.com>,
Paul Turner <pjt@google.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH v3 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork()
Date: Thu, 2 Jun 2016 02:58:33 +0800 [thread overview]
Message-ID: <20160601185833.GW18670@intel.com> (raw)
In-Reply-To: <CAKfTPtAT3JaVdSQUHvknQWAmPMhndCy6ZVw92Esg-w2OCTGgtQ@mail.gmail.com>
On Wed, Jun 01, 2016 at 02:24:29PM +0200, Vincent Guittot wrote:
> On 1 June 2016 at 05:41, Yuyang Du <yuyang.du@intel.com> wrote:
> > Move new task initialization to sched_fork(). For initial non-fair class
> > task, the first switched_to_fair() will do the attach correctly.
>
> Not sure to catch the explanation. you have only moved and renamed
> init_entity_runnable_average but you speak about initial non-fair
> class
The non-fair class task mentioning is that I stopped a bit to figure
out whether only call sched_fork_fair(), but obviously sched classes
can change, so we should call sched_fork.
And this patch is ammeneable to the previous fix to switched_to().
next prev parent reply other threads:[~2016-06-02 2:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 3:41 [PATCH v3 0/5] sched/fair: Fix attach and detach sched avgs for task group change or sched class change Yuyang Du
2016-06-01 3:41 ` [PATCH v3 1/5] sched/fair: Clean up attach_entity_load_avg() Yuyang Du
2016-06-01 3:41 ` [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Yuyang Du
2016-06-01 12:20 ` Vincent Guittot
2016-06-01 19:21 ` Yuyang Du
2016-06-02 7:29 ` Vincent Guittot
2016-06-01 23:41 ` Yuyang Du
2016-06-02 7:40 ` Vincent Guittot
2016-06-01 23:50 ` Yuyang Du
2016-06-01 3:41 ` [PATCH v3 3/5] sched/fair: Skip detach sched avgs for new task when changing task groups Yuyang Du
2016-06-01 3:41 ` [PATCH v3 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork() Yuyang Du
2016-06-01 12:24 ` Vincent Guittot
2016-06-01 18:58 ` Yuyang Du [this message]
2016-06-01 3:41 ` [PATCH v3 5/5] sched/fair: Add inline to detach_entity_load_evg() Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601185833.GW18670@intel.com \
--to=yuyang.du@intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=umgwanakikbuti@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.