From: Yuyang Du <yuyang.du@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Benjamin Segall <bsegall@google.com>,
Paul Turner <pjt@google.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH v3 2/5] sched/fair: Skip detach and attach new group task
Date: Thu, 2 Jun 2016 07:41:11 +0800 [thread overview]
Message-ID: <20160601234111.GA8105@intel.com> (raw)
In-Reply-To: <CAKfTPtBrh1thRMtA2Y5S17M_8d2BtBsCyCdWOAyFkr8-9jeKVA@mail.gmail.com>
On Thu, Jun 02, 2016 at 09:29:53AM +0200, Vincent Guittot wrote:
> > My response to your above two comments:
> >
> > As I said, there can be four possibilities going through the above sequences:
> >
> > (1) on_rq, (2) !on_rq, (a) was fair class (representing last_update_time != 0),
> > (b) never was fair class (representing last_update_time == 0, but may not be
> > limited to this)
> >
> > Crossing them, we have (1)(a), (1)(b), (2)(a), and (2)(b).
> >
> > Some will attach twice, which are (1)(b) and (2)(b), the other will attach
> > once, which are (1)(a) and (2)(a). The difficult part is they can be attached
> > at different places.
>
> ok for (1)(b) but not for (2)(b) and it's far from "attached mostly
> twice every time"
You are right. That claim is reckless, I will change it to:
"sometimes attached twice".
next prev parent reply other threads:[~2016-06-02 7:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 3:41 [PATCH v3 0/5] sched/fair: Fix attach and detach sched avgs for task group change or sched class change Yuyang Du
2016-06-01 3:41 ` [PATCH v3 1/5] sched/fair: Clean up attach_entity_load_avg() Yuyang Du
2016-06-01 3:41 ` [PATCH v3 2/5] sched/fair: Skip detach and attach new group task Yuyang Du
2016-06-01 12:20 ` Vincent Guittot
2016-06-01 19:21 ` Yuyang Du
2016-06-02 7:29 ` Vincent Guittot
2016-06-01 23:41 ` Yuyang Du [this message]
2016-06-02 7:40 ` Vincent Guittot
2016-06-01 23:50 ` Yuyang Du
2016-06-01 3:41 ` [PATCH v3 3/5] sched/fair: Skip detach sched avgs for new task when changing task groups Yuyang Du
2016-06-01 3:41 ` [PATCH v3 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork() Yuyang Du
2016-06-01 12:24 ` Vincent Guittot
2016-06-01 18:58 ` Yuyang Du
2016-06-01 3:41 ` [PATCH v3 5/5] sched/fair: Add inline to detach_entity_load_evg() Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601234111.GA8105@intel.com \
--to=yuyang.du@intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=umgwanakikbuti@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.