[PATCH] gpio: davinci: fix missed parent conversion

[PATCH] gpio: davinci: fix missed parent conversion

[Matwey V. Kornilov]

From: Linus Walleij <linus.walleij@linaro.org>

commit 6ddbaed3eff9f60d29805413404251670d2e8f0c upstream.

Please apply

6ddbaed3eff9 ("gpio: davinci: fix missed parent conversion")

to 4.4.x branch in order to avoid the following build failure on 4.4.12:

[ 2420s] ../drivers/gpio/gpio-davinci.c: In function 'davinci_gpio_probe':
[ 2420s] ../drivers/gpio/gpio-davinci.c:257:16: error: 'struct gpio_chip' has no member named 'dev'
[ 2420s]    chips[i].chip.dev = dev;
[ 2420s]                 ^
[ 2420s] ../scripts/Makefile.build:259: recipe for target 'drivers/gpio/gpio-davinci.o' failed
[ 2420s] make[4]: *** [drivers/gpio/gpio-davinci.o] Error 1
[ 2420s] ../scripts/Makefile.build:418: recipe for target 'drivers/gpio' failed
[ 2420s] make[3]: *** [drivers/gpio] Error 2

Re: [PATCH] gpio: davinci: fix missed parent conversion

[Greg KH]

On Fri, Jun 03, 2016 at 06:51:53PM +0300, Matwey V. Kornilov wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> 
> commit 6ddbaed3eff9f60d29805413404251670d2e8f0c upstream.
> 
> Please apply
> 
> 6ddbaed3eff9 ("gpio: davinci: fix missed parent conversion")
> 
> to 4.4.x branch in order to avoid the following build failure on 4.4.12:

Now applied, thanks.

greg k-h

Re: [PATCH] gpio: davinci: fix missed parent conversion

[Greg KH]

On Sun, Jun 05, 2016 at 01:52:04PM -0700, Greg KH wrote:
> On Fri, Jun 03, 2016 at 06:51:53PM +0300, Matwey V. Kornilov wrote:
> > From: Linus Walleij <linus.walleij@linaro.org>
> > 
> > commit 6ddbaed3eff9f60d29805413404251670d2e8f0c upstream.
> > 
> > Please apply
> > 
> > 6ddbaed3eff9 ("gpio: davinci: fix missed parent conversion")
> > 
> > to 4.4.x branch in order to avoid the following build failure on 4.4.12:
> 
> Now applied, thanks.

No, this broke the build, are you sure you needed this?  I suspect
something else is going wrong here...

thanks,

greg k-h

Re: [PATCH] gpio: davinci: fix missed parent conversion

[Matwey V. Kornilov]

2016-06-08 4:01 GMT+03:00 Greg KH <greg@kroah.com>:
> On Sun, Jun 05, 2016 at 01:52:04PM -0700, Greg KH wrote:
>> On Fri, Jun 03, 2016 at 06:51:53PM +0300, Matwey V. Kornilov wrote:
>> > From: Linus Walleij <linus.walleij@linaro.org>
>> >
>> > commit 6ddbaed3eff9f60d29805413404251670d2e8f0c upstream.
>> >
>> > Please apply
>> >
>> > 6ddbaed3eff9 ("gpio: davinci: fix missed parent conversion")
>> >
>> > to 4.4.x branch in order to avoid the following build failure on 4.4.12:
>>
>> Now applied, thanks.
>
> No, this broke the build, are you sure you needed this?  I suspect
> something else is going wrong here...

I've just checked another time, this commit must NOT be in 4.4.x.
I was completely sure that I was working with vanilla kernel branch.
I am sorry, I will be more careful next time.

>
> thanks,
>
> greg k-h
>



-- 
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382

[PATCH] gpio: davinci: fix missed parent conversion

[Linus Walleij]

I missed to convert this driver properly to use .parent to
point to the parent device. ARMv7 multiplatform would not
compile.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-davinci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 9fd32f76ffa7..65ebaef935e1 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -254,7 +254,7 @@ static int davinci_gpio_probe(struct platform_device *pdev)
 #ifdef CONFIG_OF_GPIO
 		chips[i].chip.of_gpio_n_cells = 2;
 		chips[i].chip.of_xlate = davinci_gpio_of_xlate;
-		chips[i].chip.dev = dev;
+		chips[i].chip.parent = dev;
 		chips[i].chip.of_node = dev->of_node;
 #endif
 		spin_lock_init(&chips[i].lock);
-- 
2.4.3