From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: bcm2835: Fix compiler warning on arm64.
Date: Mon, 6 Jun 2016 09:53:38 +0530 [thread overview]
Message-ID: <20160606042337.GT16910@localhost> (raw)
In-Reply-To: <1465007013-5300-1-git-send-email-eric@anholt.net>
On Fri, Jun 03, 2016 at 07:23:33PM -0700, Eric Anholt wrote:
> The min() macro was complaining about mismatched types. The max len
> is at most SZ_1G, so we can just put it in an unsigned int.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>
> Vinod, if you ack it, this one would be nice to be able to merge
> through the -soc tree, so that when we enable of arm64 builds of this
> driver we don't introduce a new compiler warning.
>
> drivers/dma/bcm2835-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 6149b27c33ad..1fa11fc067c6 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -393,7 +393,7 @@ static void bcm2835_dma_fill_cb_chain_with_sg(
> unsigned int sg_len)
> {
> struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
> - size_t max_len = bcm2835_dma_max_frame_length(c);
> + unsigned int max_len = bcm2835_dma_max_frame_length(c);
bcm2835_dma_max_frame_length() returns size_t. so this should also add a
complain about type mismatch as well!
Also, wouldn't it be better to make both args of min() as size_t then?
> unsigned int i, len;
> dma_addr_t addr;
> struct scatterlist *sgent;
> --
> 2.8.0.rc3
>
Thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Eric Anholt <eric@anholt.net>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dma: bcm2835: Fix compiler warning on arm64.
Date: Mon, 6 Jun 2016 09:53:38 +0530 [thread overview]
Message-ID: <20160606042337.GT16910@localhost> (raw)
In-Reply-To: <1465007013-5300-1-git-send-email-eric@anholt.net>
On Fri, Jun 03, 2016 at 07:23:33PM -0700, Eric Anholt wrote:
> The min() macro was complaining about mismatched types. The max len
> is at most SZ_1G, so we can just put it in an unsigned int.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
>
> Vinod, if you ack it, this one would be nice to be able to merge
> through the -soc tree, so that when we enable of arm64 builds of this
> driver we don't introduce a new compiler warning.
>
> drivers/dma/bcm2835-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 6149b27c33ad..1fa11fc067c6 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -393,7 +393,7 @@ static void bcm2835_dma_fill_cb_chain_with_sg(
> unsigned int sg_len)
> {
> struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
> - size_t max_len = bcm2835_dma_max_frame_length(c);
> + unsigned int max_len = bcm2835_dma_max_frame_length(c);
bcm2835_dma_max_frame_length() returns size_t. so this should also add a
complain about type mismatch as well!
Also, wouldn't it be better to make both args of min() as size_t then?
> unsigned int i, len;
> dma_addr_t addr;
> struct scatterlist *sgent;
> --
> 2.8.0.rc3
>
Thanks
--
~Vinod
next prev parent reply other threads:[~2016-06-06 4:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 2:23 [PATCH] dma: bcm2835: Fix compiler warning on arm64 Eric Anholt
2016-06-04 2:23 ` Eric Anholt
2016-06-06 4:23 ` Vinod Koul [this message]
2016-06-06 4:23 ` Vinod Koul
2016-06-06 17:15 ` Eric Anholt
2016-06-06 17:15 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606042337.GT16910@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.