From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
Ilya Maximets <i.maximets@samsung.com>,
jonshin@cisco.com, Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [Qemu-devel] [PATCH 07/10] vhost-net: save & restore vhost-user acked features
Date: Mon, 6 Jun 2016 17:06:49 +0800 [thread overview]
Message-ID: <20160606090649.GA30154@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1462896240-30999-8-git-send-email-marcandre.lureau@redhat.com>
On Tue, May 10, 2016 at 06:03:57PM +0200, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The initial vhost-user connection sets the features to be negotiated
> with the driver. Renegotiation isn't possible without device reset.
>
> To handle reconnection of vhost-user backend, ensure the same set of
> features are provided, and reuse already acked features.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/net/vhost_net.c | 21 ++++++++++++++++++++-
> include/net/vhost-user.h | 1 +
> include/net/vhost_net.h | 3 +++
> net/vhost-user.c | 10 ++++++++++
> 4 files changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 805a0df..f3df18c 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -120,6 +120,11 @@ uint64_t vhost_net_get_max_queues(VHostNetState *net)
> return net->dev.max_queues;
> }
>
> +uint64_t vhost_net_get_acked_features(VHostNetState *net)
> +{
> + return net->dev.acked_features;
> +}
Note that you need add a dummy implementation for !VHOST_NET. Otherwise,
build won't work.
And sorry for being noisy, here is another ping about the status of
this patch set.
--yliu
next prev parent reply other threads:[~2016-06-06 9:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 16:03 [Qemu-devel] [PATCH 00/10] RFCv3: vhost-user: simple reconnection support marcandre.lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 01/10] vhost-user: add ability to know vhost-user backend disconnection marcandre.lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 02/10] vubr: add client mode marcandre.lureau
2016-05-10 17:19 ` Yuanhan Liu
2016-05-10 18:08 ` Marc-André Lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 03/10] vubr: workaround stale vring base marcandre.lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 04/10] qemu-char: add qemu_chr_disconnect to close a fd accepted by listen fd marcandre.lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 05/10] vhost-user: disconnect on start failure marcandre.lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 06/10] vhost-net: do not crash if backend is not present marcandre.lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 07/10] vhost-net: save & restore vhost-user acked features marcandre.lureau
2016-06-06 9:06 ` Yuanhan Liu [this message]
2016-06-06 9:50 ` Marc-André Lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 08/10] vhost-net: save & restore vring enable state marcandre.lureau
2016-05-10 16:03 ` [Qemu-devel] [PATCH 09/10] tests: append i386 tests marcandre.lureau
2016-05-10 16:04 ` [Qemu-devel] [PATCH 10/10] test: start vhost-user reconnect test marcandre.lureau
2016-05-10 16:19 ` [Qemu-devel] [PATCH 00/10] RFCv3: vhost-user: simple reconnection support Michael S. Tsirkin
2016-05-10 16:28 ` Marc-André Lureau
2016-05-13 18:30 ` Marc-André Lureau
2016-05-15 9:42 ` Michael S. Tsirkin
2016-05-23 13:40 ` Yuanhan Liu
2016-05-24 13:24 ` Marc-André Lureau
2016-05-10 17:14 ` Yuanhan Liu
-- strict thread matches above, loose matches on Subject: below --
2016-06-06 16:44 [Qemu-devel] [PATCH 00/10] " marcandre.lureau
2016-06-06 16:45 ` [Qemu-devel] [PATCH 07/10] vhost-net: save & restore vhost-user acked features marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606090649.GA30154@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=i.maximets@samsung.com \
--cc=jonshin@cisco.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=mukawa@igel.co.jp \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.