From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: robert-4JaGZRWAfWbajFs6igw21g@public.gmane.org,
matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
leon-2ukJVAZIZ/Y@public.gmane.org,
sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 1/2] IB/core: Fix bit curruption in ib_device_cap_flags structure
Date: Mon, 6 Jun 2016 10:03:50 -0700 [thread overview]
Message-ID: <20160606170350.GA28622@infradead.org> (raw)
In-Reply-To: <1465230880-25953-2-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Mon, Jun 06, 2016 at 07:34:39PM +0300, Max Gurtovoy wrote:
> ib_device_cap_flags 64-bit expansion caused caps overlapping
> and made consumers read wrong device capabilities. For example
> IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing
> it to use a non-existing capability. This happened because signed
> int becomes sign extended when converted it to u64. Fix this by
> casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL.
Looks good,
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: robert@leblancnet.us, matanb@mellanox.com, leon@leon.nu,
sagi@grimberg.me, linux-rdma@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] IB/core: Fix bit curruption in ib_device_cap_flags structure
Date: Mon, 6 Jun 2016 10:03:50 -0700 [thread overview]
Message-ID: <20160606170350.GA28622@infradead.org> (raw)
In-Reply-To: <1465230880-25953-2-git-send-email-maxg@mellanox.com>
On Mon, Jun 06, 2016 at 07:34:39PM +0300, Max Gurtovoy wrote:
> ib_device_cap_flags 64-bit expansion caused caps overlapping
> and made consumers read wrong device capabilities. For example
> IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing
> it to use a non-existing capability. This happened because signed
> int becomes sign extended when converted it to u64. Fix this by
> casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-06-06 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 16:34 [PATCH v3 0/2] fix ib_device_cap_flags bit curruption Max Gurtovoy
2016-06-06 16:34 ` [PATCH v3 1/2] IB/core: Fix bit curruption in ib_device_cap_flags structure Max Gurtovoy
[not found] ` <1465230880-25953-2-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-06 17:03 ` Christoph Hellwig [this message]
2016-06-06 17:03 ` Christoph Hellwig
[not found] ` <1465230880-25953-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-06 16:34 ` [PATCH v3 2/2] IB/core: Align casting method of ib_device_cap_flags enumerations to ULL Max Gurtovoy
2016-06-06 16:34 ` Max Gurtovoy
2016-06-06 17:04 ` Christoph Hellwig
[not found] ` <20160606170413.GB28622-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-06-06 17:15 ` Greg KH
2016-06-06 17:15 ` Greg KH
[not found] ` <20160606171543.GA14882-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-06-06 17:22 ` Christoph Hellwig
2016-06-06 17:22 ` Christoph Hellwig
2016-06-06 18:31 ` Max Gurtovoy
2016-06-06 18:31 ` Max Gurtovoy
[not found] ` <CALq1K=JWPk6nPjTV0z1HwfmtnO77Nkyaqx-JTB=8JwH0UtorDA@mail.gmail.com>
[not found] ` <CALq1K=JWPk6nPjTV0z1HwfmtnO77Nkyaqx-JTB=8JwH0UtorDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-06 17:22 ` hch
2016-06-06 17:22 ` hch
2016-06-06 17:40 ` Greg KH
[not found] ` <20160606174011.GB24836-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-06-06 17:45 ` Bart Van Assche
2016-06-06 17:45 ` Bart Van Assche
2016-06-07 12:00 ` [PATCH v3 0/2] fix ib_device_cap_flags bit curruption Doug Ledford
2016-06-07 12:00 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606170350.GA28622@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=leon-2ukJVAZIZ/Y@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=robert-4JaGZRWAfWbajFs6igw21g@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.